From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: don't allow bmap/swap on rt files
Date: Mon, 19 Jun 2017 23:37:23 -0700 [thread overview]
Message-ID: <20170620063723.GA2250@infradead.org> (raw)
In-Reply-To: <20170619202314.GB4733@birch.djwong.org>
On Mon, Jun 19, 2017 at 01:23:14PM -0700, Darrick J. Wong wrote:
> bmap returns a dumb LBA address but not the block device that goes with
> that LBA. Swapfiles don't care about this and will blindly assume that
> the data volume is the correct blockdev, which is totally bogus for
> files on the rt subvolume. This results in the swap code doing IOs to
> arbitrary locations on the data device(!) if the passed in mapping is a
> realtime file, so just turn off bmap for rt files.
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2017-06-20 6:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 20:23 [PATCH] xfs: don't allow bmap/swap on rt files Darrick J. Wong
2017-06-20 6:37 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620063723.GA2250@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).