From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
list@jonas-server.de, David Shaw <dshaw@jabberwocky.com>,
Emmanuel Florac <eflorac@intellique.com>,
Brian Foster <bfoster@redhat.com>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: don't crash on unexpected holes in dir/attr btrees
Date: Tue, 20 Jun 2017 02:06:07 -0700 [thread overview]
Message-ID: <20170620090607.GD15374@infradead.org> (raw)
In-Reply-To: <351d0c66-4969-7ce9-da9c-6d2901e1bdef@sandeen.net>
On Fri, Jun 16, 2017 at 01:12:41PM -0500, Eric Sandeen wrote:
> On 6/16/17 12:53 PM, Darrick J. Wong wrote:
> > Hi all,
> >
> > So I /think/ the xfs_attr_inactive crashes that both of you have been
> > seeing are a result of XFS assuming that there aren't ever any mapping
> > holes in the extended attribute fork and crashing when it tries to
> > grab a buffer for the hole and fails to notice that holes don't have
> > buffers. This lightly tested patch gets rid of /that/ problem.
> >
> > So, if you're willing, can you try this out and see if the crashes go
> > away? Granted, this might only enable us to lurch on whatever's next...
>
> If it's unexpected, does that mean something else is wrong? If so,
> should there be a warning or a corrupted state, or anything like that?
xfs_attr_rmtval_remove certainly removes blocks from the attr mapping,
but those should be expected..
next prev parent reply other threads:[~2017-06-20 9:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 17:53 [PATCH] xfs: don't crash on unexpected holes in dir/attr btrees Darrick J. Wong
2017-06-16 18:12 ` Eric Sandeen
2017-06-20 9:06 ` Christoph Hellwig [this message]
2017-06-26 16:04 ` Darrick J. Wong
2017-06-20 13:01 ` David Shaw
2017-06-20 16:20 ` Darrick J. Wong
2017-07-06 21:59 ` David Shaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620090607.GD15374@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=dshaw@jabberwocky.com \
--cc=eflorac@intellique.com \
--cc=linux-xfs@vger.kernel.org \
--cc=list@jonas-server.de \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).