From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:45562 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750859AbdFTSFH (ORCPT ); Tue, 20 Jun 2017 14:05:07 -0400 Date: Tue, 20 Jun 2017 20:05:05 +0200 From: "Luis R. Rodriguez" Subject: Re: [PATCH 2/2] xfs: Properly retry failed inode items in case of error during buffer writeback Message-ID: <20170620180505.GT21846@wotan.suse.de> References: <20170616105445.3314-1-cmaiolino@redhat.com> <20170616105445.3314-3-cmaiolino@redhat.com> <20170616183510.GC21846@wotan.suse.de> <20170616192445.GG5421@birch.djwong.org> <20170616193755.GD21846@wotan.suse.de> <3ff0e0c8-ef9c-b7f8-d37e-ed02e5766c40@sandeen.net> <20170619105904.GA25255@bfoster.bfoster> <20170620165204.GP21846@wotan.suse.de> <20170620172041.GD3348@bfoster.bfoster> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170620172041.GD3348@bfoster.bfoster> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Brian Foster Cc: "Luis R. Rodriguez" , Eric Sandeen , "Darrick J. Wong" , Carlos Maiolino , linux-xfs@vger.kernel.org On Tue, Jun 20, 2017 at 01:20:41PM -0400, Brian Foster wrote: > On Tue, Jun 20, 2017 at 06:52:04PM +0200, Luis R. Rodriguez wrote: > > On Mon, Jun 19, 2017 at 06:59:05AM -0400, Brian Foster wrote: > > > It hasn't seemed necessary to me to take that approach given the lower > > > prevalence of the issue > > > > Of this issue? I suppose its why I asked about examples of issues, I seem > > to have found it likely much more possible out in the wild than expected. > > It would seem folks might be working around it somehow. > > > > If we're talking about the thin provisioning case, I suspect most people > work around it by properly configuring their storage. ;) The fact that we *hang* makes it more serious, so even if folks misconfigured storage with less space it should be no reason to consider hangs any less severe. Specially if it seems to be a common issue, and I'm alluding to the fact that this might be more common than the patch describes. Luis