From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Bill O'Donnell <billodo@redhat.com>
Cc: linux-xfs@vger.kernel.org, sandeen@sandeen.net
Subject: Re: [PATCH] xfs_spaceman: close open file for error case in openfile()
Date: Thu, 29 Jun 2017 09:27:05 -0700 [thread overview]
Message-ID: <20170629162704.GD5874@birch.djwong.org> (raw)
In-Reply-To: <20170629162530.6023-1-billodo@redhat.com>
On Thu, Jun 29, 2017 at 11:25:30AM -0500, Bill O'Donnell wrote:
> openfile() fails to close the open file in one error case.
> Add close(fd) to correct the condition.
>
> Detected by CoverityScan, CID#1413770 (RESOURCE_LEAK)
>
> Signed-off-by: Bill O'Donnell <billodo@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> spaceman/file.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/spaceman/file.c b/spaceman/file.c
> index 4ab30900..4c13b4a8 100644
> --- a/spaceman/file.c
> +++ b/spaceman/file.c
> @@ -79,6 +79,7 @@ openfile(
> if (!fsp) {
> fprintf(stderr, _("%s: cannot find mount point."),
> path);
> + close(fd);
> return -1;
> }
> memcpy(fs_path, fsp, sizeof(struct fs_path));
> --
> 2.13.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-06-29 16:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 16:25 [PATCH] xfs_spaceman: close open file for error case in openfile() Bill O'Donnell
2017-06-29 16:27 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629162704.GD5874@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=billodo@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox