From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: eguan@redhat.com
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH v2 12/8] ext4: don't online scrub ever
Date: Thu, 29 Jun 2017 21:58:12 -0700 [thread overview]
Message-ID: <20170630045812.GI5871@birch.djwong.org> (raw)
In-Reply-To: <20170630041331.GG5871@birch.djwong.org>
The ext4 online scrub program is no longer under active development,
so remove all the test code that tried to use it.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
v2: Fix the description to match what it does now
---
common/fuzzy | 2 +-
tests/ext4/023 | 7 ++++---
tests/ext4/023.out | 2 +-
3 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/common/fuzzy b/common/fuzzy
index 304268e..686cf77 100644
--- a/common/fuzzy
+++ b/common/fuzzy
@@ -70,7 +70,7 @@ _require_scrub() {
# Scrub the scratch filesystem metadata (online)
_scratch_scrub() {
case "${FSTYP}" in
- "xfs"|"ext4"|"ext3"|"ext2")
+ "xfs")
$XFS_SCRUB_PROG -d -T -v "$@" $SCRATCH_MNT
;;
*)
diff --git a/tests/ext4/023 b/tests/ext4/023
index 4f5cf3e..7ca3d7d 100755
--- a/tests/ext4/023
+++ b/tests/ext4/023
@@ -1,7 +1,9 @@
#! /bin/bash
# FS QA Test No. 023
#
-# Populate a ext4 filesystem and ensure that scrub and repair are happy.
+# Ensure that the populate helpers actually /can/ populate a ext4
+# filesystem with all types of metadata and create an image of the
+# metadata. Check that fsck is happy with the resulting fs.
#
#-----------------------------------------------------------------------
# Copyright (c) 2017 Oracle, Inc. All Rights Reserved.
@@ -51,9 +53,8 @@ _require_scrub
echo "Format and populate"
_scratch_populate_cached > $seqres.full 2>&1
-echo "Scrub"
+echo "Mount"
_scratch_mount >> $seqres.full 2>&1
-_scratch_scrub >> $seqres.full
# success, all done
status=0
diff --git a/tests/ext4/023.out b/tests/ext4/023.out
index da2bd60..8a7659b 100644
--- a/tests/ext4/023.out
+++ b/tests/ext4/023.out
@@ -1,3 +1,3 @@
QA output created by 023
Format and populate
-Scrub
+Mount
next prev parent reply other threads:[~2017-06-30 4:58 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 21:57 [PATCH 0/8] miscellaneous tests Darrick J. Wong
2017-06-21 21:57 ` [PATCH 1/8] ext4: fsmap tests Darrick J. Wong
2017-06-23 7:41 ` Eryu Guan
2017-06-23 15:35 ` Darrick J. Wong
2017-06-21 21:57 ` [PATCH 2/8] xfs/274: flip shared bits to reflect xfsprogs usage Darrick J. Wong
2017-06-21 21:57 ` [PATCH 3/8] xfs: don't allow realtime swap files Darrick J. Wong
2017-06-21 21:57 ` [PATCH 4/8] xfs/040: use compare-libxfs in xfsprogs Darrick J. Wong
2017-06-21 21:57 ` [PATCH 5/8] reflink: test unlinking a huge extent with a lot of refcount adjustments Darrick J. Wong
2017-06-29 9:36 ` Eryu Guan
2017-06-29 16:07 ` Darrick J. Wong
2017-06-29 17:19 ` Eryu Guan
2017-06-21 21:57 ` [PATCH 6/8] xfs: test that we can SEEK_HOLE/DATA data and holes that are in the CoW fork only Darrick J. Wong
2017-06-21 21:58 ` [PATCH 7/8] xfs: test freeze/rmap repair race Darrick J. Wong
2017-06-29 9:47 ` Eryu Guan
2017-06-29 17:17 ` Darrick J. Wong
2017-06-21 21:58 ` [PATCH 8/8] xfs: scrub while appending to a file Darrick J. Wong
2017-06-22 6:26 ` [PATCH 9/8] common/populate: remember multi-device configurations Darrick J. Wong
2017-06-23 7:49 ` Eryu Guan
2017-06-23 15:34 ` Darrick J. Wong
2017-06-30 4:12 ` [PATCH v2 " Darrick J. Wong
2017-06-23 7:59 ` [PATCH 0/8] miscellaneous tests Eryu Guan
2017-06-30 4:12 ` [PATCH 10/8] common/rc: test that the xfs_io scrub/repair commands actually work Darrick J. Wong
2017-06-30 4:13 ` [PATCH 11/8] common/inject: refactor helpers to use new errortag interface Darrick J. Wong
2017-07-05 12:16 ` Brian Foster
2017-07-05 16:29 ` Darrick J. Wong
2017-07-05 16:45 ` Brian Foster
2017-07-05 21:05 ` Darrick J. Wong
2017-07-06 10:07 ` Brian Foster
2017-06-30 4:13 ` [PATCH 12/8] ext4: don't online scrub ever Darrick J. Wong
2017-06-30 4:22 ` Eryu Guan
2017-06-30 4:26 ` Darrick J. Wong
2017-06-30 4:33 ` Eryu Guan
2017-06-30 4:58 ` Darrick J. Wong [this message]
2017-06-30 12:32 ` [PATCH v2 " Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170630045812.GI5871@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).