From: Brian Foster <bfoster@redhat.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH v2 0/6] xfs: log recovery wrap and tail overwrite fixes
Date: Mon, 10 Jul 2017 09:27:54 -0400 [thread overview]
Message-ID: <20170710132800.19506-1-bfoster@redhat.com> (raw)
Hi all,
This is v2 of the tail overwrite detection series. Patches 1-4 include
mostly minor changes to fix up some error handling issues and whatnot.
Patch 5 is new and updates both of the torn write and tail overwrite
detection mechanisms to handle corruption errors along with crc mismatch
errors. Patch 6 is also new and a trivial introduction of a tracepoint.
This has survived a decent amount of testing to this point with various
block sizes, logbsize values, and feature settings (debug on/off, crc
on/off, reflink on/off) on a couple different arches (x86-64, ppc64).
Thoughts, reviews, flames appreciated.
Brian
v2:
- Fix 64-bit division.
- Fix up error checking in xlog_verify_[head|tail]() to only move tail
tail on corruption and otherwise fail mount immediately.
- Added patch 5 to handle -EFSCORRUPTED on head/tail verification.
- Added patch 6 to introduce log head/tail tracepoint.
v1: http://www.spinics.net/lists/linux-xfs/msg07974.html
- Add patch to fix log recovery header wrapping problem.
- Replace transaction reservation rfc with log recovery based fix.
- Replace custom log pinning sysfs knob with error injection tag.
rfc: http://www.spinics.net/lists/linux-xfs/msg07623.html
Brian Foster (6):
xfs: fix recovery failure when log record header wraps log end
xfs: always verify the log tail during recovery
xfs: fix log recovery corruption error due to tail overwrite
xfs: add log item pinning error injection tag
xfs: handle -EFSCORRUPTED during head/tail verification
xfs: add log recovery tracepoint for head/tail
fs/xfs/xfs_error.c | 3 +
fs/xfs/xfs_error.h | 4 +-
fs/xfs/xfs_log_recover.c | 157 +++++++++++++++++++++++++++++------------------
fs/xfs/xfs_trace.h | 18 ++++++
fs/xfs/xfs_trans_ail.c | 17 ++++-
5 files changed, 137 insertions(+), 62 deletions(-)
--
2.9.4
next reply other threads:[~2017-07-10 13:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 13:27 Brian Foster [this message]
2017-07-10 13:27 ` [PATCH v2 1/6] xfs: fix recovery failure when log record header wraps log end Brian Foster
2017-07-10 13:27 ` [PATCH v2 2/6] xfs: always verify the log tail during recovery Brian Foster
2017-07-10 13:27 ` [PATCH v2 3/6] xfs: fix log recovery corruption error due to tail overwrite Brian Foster
2017-07-10 13:27 ` [PATCH v2 4/6] xfs: add log item pinning error injection tag Brian Foster
2017-07-10 13:27 ` [PATCH v2 5/6] xfs: handle -EFSCORRUPTED during head/tail verification Brian Foster
2017-07-10 13:28 ` [PATCH v2 6/6] xfs: add log recovery tracepoint for head/tail Brian Foster
2017-07-13 5:21 ` [PATCH v2 0/6] xfs: log recovery wrap and tail overwrite fixes Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170710132800.19506-1-bfoster@redhat.com \
--to=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox