Re: [PATCH 3/7] mkfs: remove intermediate getstr followed by getnum

Eric Sandeen
2017-07-27T13:35:41Z

On 7/27/17 2:50 AM, Jan Tulak wrote:
> On Wed, Jul 26, 2017 at 10:49 PM, Eric Sandeen <sandeen@sandeen.net> wrote:
>> On 7/20/17 10:54 AM, Darrick J. Wong wrote:

...

>>> Why has dbytes been demoted from uint64_t to int? This eliminates the
>>> ability to -d size=8G, right?
>>
>> That wasn't a problem in the version I reviewed.... pls don't keep reviewed-by's
>> on patches that change from the reviewed version. Further, best to indicate
>> explicitly what has changed since the last version, under the "---"
>>
>
> Yes, I'm sorry about that. :( I forgot to remove the Reviewed-by after
> rebasing it without the uint64 change. :(

No problem, just a friendly reminder. :)

-Eric