From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: David Shaw <dshaw@jabberwocky.com>
Cc: "Jory A. Pratt" <anarchy@gentoo.org>,
cmaiolino@redhat.com, xfs <linux-xfs@vger.kernel.org>
Subject: Re: xfsprogs commit 4944defad4ae2cbcf056207490d7c597bb92cd7c
Date: Mon, 24 Jul 2017 22:56:59 -0700 [thread overview]
Message-ID: <20170725055659.GC4369@magnolia> (raw)
In-Reply-To: <8A0CFE17-BAB8-4CC9-8A01-BFD99F6C83FE@jabberwocky.com>
[cc xfs list]
On Sun, Jul 23, 2017 at 10:21:56AM -0400, David Shaw wrote:
> On Jul 22, 2017, at 10:13 PM, Jory A. Pratt <anarchy@gentoo.org> wrote:
> >
> > Is there any specific reason you all have drop'd away from the posix
> > standard? This change introduces build failure as it no longer follows
> > the posix standard for stdout.
> >
> > metadump.c:2875:10: error: assignment of read-only variable 'stdout'
> > stdout = stderr;
> > ^
> > metadump.c:2911:10: error: assignment of read-only variable 'stdout'
> > stdout = outf;
Huh? What system configuration (libc, etc.) is this?
The Open Group Base Specifications Issue 7
http://pubs.opengroup.org/onlinepubs/9699919799/functions/stdin.html
only mentions this:
extern FILE *stderr, *stdin, *stdout;
and says that it defers to the ISO C standard.
The ISO C11 standard (draft 1570, anyway)
https://port70.net/~nsz/c/c11/n1570.txt
has this to say:
stderr
stdin
stdout
which are expressions of type ''pointer to FILE'' that point to the
FILE objects associated, respectively, with the standard error,
input, and output streams.
I don't see anything in there about stdout being read only, though I
suppose there's nothing in that explicitly requiring they be assignable.
<grumble> musl, isn't it...?
--D
>
> Hi,
>
> I think you may have meant this to go to Darrick Wong
> (darrick.wong@oracle.com), cc'd. I reported the bug (well,
> indirectly), but Darrick was the person who fixed it.
>
> David
>
next parent reply other threads:[~2017-07-25 5:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <c16e39da-27dd-d35c-e9e1-463d36472a8b@gentoo.org>
[not found] ` <8A0CFE17-BAB8-4CC9-8A01-BFD99F6C83FE@jabberwocky.com>
2017-07-25 5:56 ` Darrick J. Wong [this message]
2017-07-25 9:51 ` xfsprogs commit 4944defad4ae2cbcf056207490d7c597bb92cd7c Jory A. Pratt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170725055659.GC4369@magnolia \
--to=darrick.wong@oracle.com \
--cc=anarchy@gentoo.org \
--cc=cmaiolino@redhat.com \
--cc=dshaw@jabberwocky.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox