From: Christoph Hellwig <hch@lst.de>
To: Nikolay Borisov <n.borisov.lkml@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH, RFC] xfs: fix multi-AG deadlock in xfs_bunmapi
Date: Wed, 26 Jul 2017 15:04:42 +0200 [thread overview]
Message-ID: <20170726130442.GA24681@lst.de> (raw)
In-Reply-To: <16f95f63-1111-9d3c-344c-6b42ddab3b55@gmail.com>
On Thu, Jul 20, 2017 at 05:58:42PM +0300, Nikolay Borisov wrote:
>
>
> On 20.07.2017 10:49, Christoph Hellwig wrote:
> > On Thu, Jul 20, 2017 at 10:47:50AM +0300, Nikolay Borisov wrote:
> >>
> >>
> >> On 20.07.2017 10:47, Christoph Hellwig wrote:
> >>> Odd. And the patch to always just process a single extent from
> >>> xfs_itruncate_extents fixes the issue for you, right?
> >>
> >> As far as I remember yes.
> >
> > Can you retest it under otherwise identical conditions?
>
> Okay, I confirm that indeed changing the define from 2 to 1 fixes the
> issue.
But this is just on 4.4 and older, right? We had issues in the
allocation path there as well, which should be fixed in 4.11 and later,
and in recrnt 4.9-stable releases. Without those the allocation path
might sometimes lock out of order as well.
next prev parent reply other threads:[~2017-07-26 13:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 17:25 [PATCH, RFC] xfs: fix multi-AG deadlock in xfs_bunmapi Christoph Hellwig
2017-07-18 18:15 ` Darrick J. Wong
2017-07-18 18:27 ` Nikolay Borisov
2017-07-18 18:33 ` Darrick J. Wong
2017-07-19 7:36 ` Christoph Hellwig
2017-07-19 13:11 ` Nikolay Borisov
2017-07-19 15:09 ` Nikolay Borisov
2017-07-20 7:47 ` Christoph Hellwig
2017-07-20 7:47 ` Nikolay Borisov
2017-07-20 7:49 ` Christoph Hellwig
2017-07-20 7:51 ` Nikolay Borisov
2017-07-20 14:58 ` Nikolay Borisov
2017-07-21 10:26 ` Christoph Hellwig
2017-07-26 13:04 ` Christoph Hellwig [this message]
2017-07-26 13:59 ` Nikolay Borisov
2017-07-28 6:05 ` Nikolay Borisov
2017-07-31 12:09 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170726130442.GA24681@lst.de \
--to=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=n.borisov.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox