public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Brian Foster <bfoster@redhat.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] generic/224: filter out expected XFS warnings for mixed direct/buffer I/O
Date: Thu, 3 Aug 2017 07:53:49 -0400	[thread overview]
Message-ID: <20170803115349.GD62447@bfoster.bfoster> (raw)
In-Reply-To: <20170731042825.6250-1-eguan@redhat.com>

On Mon, Jul 31, 2017 at 12:28:24PM +0800, Eryu Guan wrote:
> generic/224 is doing concurrent direct and buffered I/O to the same
> set of files, and this triggers some expected warnings on XFS. So
> filter out these warnings just like what we did in generic/095 and
> generic/247.
> 
> Signed-off-by: Eryu Guan <eguan@redhat.com>
> ---

Reviewed-by: Brian Foster <bfoster@redhat.com>

>  tests/generic/224 | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/generic/224 b/tests/generic/224
> index 2c30a75258f3..29b1c05d06df 100755
> --- a/tests/generic/224
> +++ b/tests/generic/224
> @@ -82,5 +82,14 @@ for i in `seq 0 1 $FILES`; do
>  done
>  wait
>  echo "*** Silence is golden ***"
> -status=0
> +
> +# unmount and check dmesg, filtering out expected XFS warnings about mixed
> +# direct and buffered I/O
> +_scratch_unmount
> +if [ "$FSTYP" == "xfs" ]; then
> +	_check_dmesg _filter_xfs_dmesg
> +else
> +	_check_dmesg
> +fi
> +status=$?
>  exit
> -- 
> 2.13.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2017-08-03 11:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-31  4:28 [PATCH 1/2] generic/224: filter out expected XFS warnings for mixed direct/buffer I/O Eryu Guan
2017-07-31  4:28 ` [PATCH 2/2] common/xfs: add iomap_dio_actor() to the dmesg filter Eryu Guan
2017-08-03 11:54   ` Brian Foster
2017-08-03 11:53 ` Brian Foster [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170803115349.GD62447@bfoster.bfoster \
    --to=bfoster@redhat.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox