public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Brian Foster <bfoster@redhat.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] common/xfs: add iomap_dio_actor() to the dmesg filter
Date: Thu, 3 Aug 2017 07:54:09 -0400	[thread overview]
Message-ID: <20170803115409.GE62447@bfoster.bfoster> (raw)
In-Reply-To: <20170731042825.6250-2-eguan@redhat.com>

On Mon, Jul 31, 2017 at 12:28:25PM +0800, Eryu Guan wrote:
> The warning in fs/iomap.c::iomap_dio_actor() could be triggered when
> mixing dio and mmap I/O on the same sparse file. Several tests could
> hit this warning now, like generic/095 generic/224 and generic/446.
> So add this expected warning to whitelist too.
> 
> Signed-off-by: Eryu Guan <eguan@redhat.com>
> ---

Reviewed-by: Brian Foster <bfoster@redhat.com>

>  common/xfs | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/common/xfs b/common/xfs
> index 47b4e1ba4b7f..4995f8ba8dd8 100644
> --- a/common/xfs
> +++ b/common/xfs
> @@ -596,10 +596,12 @@ _filter_xfs_dmesg()
>  	local warn4="WARNING:.*fs/xfs/xfs_file\.c:.*xfs_file_aio_read.*"
>  	local warn5="WARNING:.*fs/iomap\.c:.*iomap_dio_rw.*"
>  	local warn6="WARNING:.*fs/xfs/xfs_aops\.c:.*__xfs_get_blocks.*"
> +	local warn7="WARNING:.*fs/iomap\.c:.*iomap_dio_actor.*"
>  	sed -e "s#$warn1#Intentional warnings in xfs_file_dio_aio_write#" \
>  	    -e "s#$warn2#Intentional warnings in xfs_file_dio_aio_read#" \
>  	    -e "s#$warn3#Intentional warnings in xfs_file_read_iter#" \
>  	    -e "s#$warn4#Intentional warnings in xfs_file_aio_read#" \
>  	    -e "s#$warn5#Intentional warnings in iomap_dio_rw#" \
> -	    -e "s#$warn6#Intentional warnings in __xfs_get_blocks#"
> +	    -e "s#$warn6#Intentional warnings in __xfs_get_blocks#" \
> +	    -e "s#$warn7#Intentional warnings in iomap_dio_actor#"
>  }
> -- 
> 2.13.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2017-08-03 11:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-31  4:28 [PATCH 1/2] generic/224: filter out expected XFS warnings for mixed direct/buffer I/O Eryu Guan
2017-07-31  4:28 ` [PATCH 2/2] common/xfs: add iomap_dio_actor() to the dmesg filter Eryu Guan
2017-08-03 11:54   ` Brian Foster [this message]
2017-08-03 11:53 ` [PATCH 1/2] generic/224: filter out expected XFS warnings for mixed direct/buffer I/O Brian Foster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170803115409.GE62447@bfoster.bfoster \
    --to=bfoster@redhat.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox