From: Christoph Hellwig <hch@infradead.org>
To: Carlos Maiolino <cmaiolino@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2 V7] xfs: Properly retry failed inode items in case of error during buffer writeback
Date: Fri, 11 Aug 2017 06:09:57 -0700 [thread overview]
Message-ID: <20170811130957.GB27121@infradead.org> (raw)
In-Reply-To: <20170724133431.11479-3-cmaiolino@redhat.com>
> }
> #endif
> +
> +static inline void
> +xfs_clear_li_failed(
> + struct xfs_log_item *lip)
> +{
> + struct xfs_buf *bp = lip->li_buf;
> +
> + ASSERT(lip->li_flags & XFS_LI_IN_AIL);
> + lockdep_assert_held(&lip->li_ailp->xa_lock);
> +
> + if (lip->li_flags & XFS_LI_FAILED) {
> + lip->li_flags &= ~XFS_LI_FAILED;
> + lip->li_buf = NULL;
> + xfs_buf_rele(bp);
This means we now nest pag->pag_buf_lock and bp->b_lock inside
ailp->xa_lock. I couldn't find any place where we take
it in a different order, but it makes me feel a little nervous.
Also I think the set/clear failed helper might better be out of line
instead of bloating the callers.
Except for that the patch looks fine to me.
next prev parent reply other threads:[~2017-08-11 13:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 13:34 [PATCH 0/2 V7] Resubmit items failed during writeback Carlos Maiolino
2017-07-24 13:34 ` [PATCH 1/2 V7] xfs: Add infrastructure needed for error propagation during buffer IO failure Carlos Maiolino
2017-08-11 13:04 ` Christoph Hellwig
2017-07-24 13:34 ` [PATCH 2/2 V7] xfs: Properly retry failed inode items in case of error during buffer writeback Carlos Maiolino
2017-08-11 13:09 ` Christoph Hellwig [this message]
2017-08-14 13:04 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170811130957.GB27121@infradead.org \
--to=hch@infradead.org \
--cc=cmaiolino@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox