public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Brian Foster <bfoster@redhat.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH RFC 0/2] xfs: refactor ordered buffer logging code
Date: Mon, 14 Aug 2017 12:54:49 -0400	[thread overview]
Message-ID: <20170814165451.43788-1-bfoster@redhat.com> (raw)

Hi all,

Here's an initial refactoring based on the discussion on Alex's empty
xattr leaf buffer holding patch [1]. These patches split off some of
xfs_trans_log_buf() into a new helper and update xfs_trans_ordered_buf()
to use it and thus eliminate the need to log dirty ranges on ordered
buffers. The secondary purpose here is to create a function that we can
call from deferred ops processing to relog an already dirty/held buffer
across transaction rolls.

Note that this has only been very lightly tested and I might have one or
two more cleanups to tack on. Thoughts, reviews, flames appreciated...

Brian

[1] http://marc.info/?l=linux-xfs&m=150227679029089&w=2

Brian Foster (2):
  xfs: refactor buffer logging into buffer dirtying helper
  xfs: don't log dirty ranges for ordered buffers

 fs/xfs/libxfs/xfs_btree.c  |  3 +-
 fs/xfs/libxfs/xfs_ialloc.c |  2 --
 fs/xfs/xfs_trans.h         |  4 ++-
 fs/xfs/xfs_trans_buf.c     | 71 ++++++++++++++++++++++++++++------------------
 4 files changed, 48 insertions(+), 32 deletions(-)

-- 
2.9.4


             reply	other threads:[~2017-08-14 16:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-14 16:54 Brian Foster [this message]
2017-08-14 16:54 ` [PATCH RFC 1/2] xfs: refactor buffer logging into buffer dirtying helper Brian Foster
2017-08-16 17:16   ` Darrick J. Wong
2017-08-14 16:54 ` [PATCH RFC 2/2] xfs: don't log dirty ranges for ordered buffers Brian Foster
2017-08-15  0:25   ` Dave Chinner
2017-08-16 17:15   ` Darrick J. Wong
2017-08-17 11:06     ` Brian Foster
2017-08-14 20:20 ` [PATCH RFC 0/2] xfs: refactor ordered buffer logging code Allison Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170814165451.43788-1-bfoster@redhat.com \
    --to=bfoster@redhat.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox