Re: [PATCH] xfs: preserve i_mode if __xfs_set_acl() fails

["Ernesto A. Fernández" <ernesto.mnd.fernandez@gmail.com>]

On Wed, Aug 16, 2017 at 11:35:02PM +1000, Dave Chinner wrote:
> On Wed, Aug 16, 2017 at 04:16:53AM -0300, Ernesto A. Fernández wrote:
> > On Wed, Aug 16, 2017 at 10:25:11AM +1000, Dave Chinner wrote:
> > > With that in mind, here's waht I suggested above: set the mode after
> > > the xattr. I haven't tested it - can you check it solves the problem
> > > case you are testing?
> > 
> > It does. Of course the test still fails, as I said before, now claiming that
> > the filesystem is inconsistent. But that's a separate issue.
> 
> It shouldn't be - what's the error that is being reported?

xfs_repair, phase 3:
bad magic number febe in block 512 (14452) for directory inode 131
problem with attribute contents in inode 131
would clear attr fork
bad nblocks 11900 for inode 131, would reset to 11274
bad anextents 1 for inode 131, would reset to 0


This is not a result of your patch, it was already happening before.
It seems to be caused by setting too many extended attributes to a
file.

> 
> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> david@fromorbit.com