From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp1040.oracle.com ([156.151.31.81]:21653 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753144AbdHQQWz (ORCPT ); Thu, 17 Aug 2017 12:22:55 -0400 Date: Thu, 17 Aug 2017 09:22:49 -0700 From: "Darrick J. Wong" Subject: Re: [PATCH 2/3] xfs: rename xfs_defer_join to xfs_defer_join_inode Message-ID: <20170817162249.GE4796@magnolia> References: <20170813144216.11192-1-hch@lst.de> <20170813144216.11192-3-hch@lst.de> <20170816172130.GA4796@magnolia> <20170817074422.GA24463@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170817074422.GA24463@lst.de> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org On Thu, Aug 17, 2017 at 09:44:22AM +0200, Christoph Hellwig wrote: > On Wed, Aug 16, 2017 at 10:21:30AM -0700, Darrick J. Wong wrote: > > On Sun, Aug 13, 2017 at 04:42:15PM +0200, Christoph Hellwig wrote: > > > Signed-off-by: Christoph Hellwig > > > --- > > > fs/xfs/libxfs/xfs_bmap.c | 2 +- > > > fs/xfs/libxfs/xfs_defer.c | 4 ++-- > > > fs/xfs/libxfs/xfs_defer.h | 2 +- > > > 3 files changed, 4 insertions(+), 4 deletions(-) > > > > > > diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c > > > index c09c16b1ad3b..24eba36ef818 100644 > > > --- a/fs/xfs/libxfs/xfs_bmap.c > > > +++ b/fs/xfs/libxfs/xfs_bmap.c > > > @@ -6452,7 +6452,7 @@ __xfs_bmap_add( > > > bi->bi_whichfork = whichfork; > > > bi->bi_bmap = *bmap; > > > > > > - error = xfs_defer_join(dfops, bi->bi_owner); > > > + error = xfs_defer_join_inode(dfops, bi->bi_owner); > > > > /me wonders if this should be named xfs_defer_ijoin to be more > > consistent with xfs_trans_ijoin, or if we should rename the other one to > > xfs_trans_join_inode instead? > > Sure. I'll resend with the __ prefix removed from __xfs_trans_roll > and this renamed to _ijoin. > > Should I also rename xfs_trans_roll_inode to xfs_trans_roll_ijoin? Ok. --D > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html