From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com ([192.55.52.120]:44972 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751843AbdHRWM2 (ORCPT ); Fri, 18 Aug 2017 18:12:28 -0400 Date: Fri, 18 Aug 2017 16:12:27 -0600 From: Ross Zwisler Subject: Re: [PATCH 07/13] dax: Inline dax_pmd_insert_mapping() into the callsite Message-ID: <20170818221226.GF32627@linux.intel.com> References: <20170817160815.30466-1-jack@suse.cz> <20170817160815.30466-8-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170817160815.30466-8-jack@suse.cz> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Jan Kara Cc: linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org, Andy Lutomirski , linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, Christoph Hellwig , Ross Zwisler , Dan Williams , Boaz Harrosh On Thu, Aug 17, 2017 at 06:08:09PM +0200, Jan Kara wrote: > dax_pmd_insert_mapping() has only one callsite and we will need to > further fine tune what it does for synchronous faults. Just inline it > into the callsite so that we don't have to pass awkward bools around. > > Signed-off-by: Jan Kara Sure, looks good. Reviewed-by: Ross Zwisler