From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp1040.oracle.com ([141.146.126.69]:46000 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932565AbdHWUOo (ORCPT ); Wed, 23 Aug 2017 16:14:44 -0400 Date: Wed, 23 Aug 2017 13:14:35 -0700 From: "Darrick J. Wong" Subject: Re: [PATCH 1/3] libxfs: handle 0 blocksize or sectorsize in cvtnum Message-ID: <20170823201435.GZ4796@magnolia> References: <2b5a5742-5343-671f-8b89-9d1dc9841c17@redhat.com> <2e0acf4a-a863-8304-65d3-5027368c69e2@sandeen.net> <20170823010153.GZ21024@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Eric Sandeen Cc: Dave Chinner , Eric Sandeen , linux-xfs On Tue, Aug 22, 2017 at 09:13:03PM -0500, Eric Sandeen wrote: > On 8/22/17 8:01 PM, Dave Chinner wrote: > > On Tue, Aug 22, 2017 at 04:12:48PM -0500, Eric Sandeen wrote: > >> Blocksize and sectorsize are unique in that they must > >> be provided, unlike every other suffix which can be > >> calculated from constants. > >> > >> Nothing protects against unspecified block & sector size, > >> so catch it if it happens and return a parsing error. > >> > >> Signed-off-by: Eric Sandeen > >> --- > >> > >> diff --git a/libxcmd/input.c b/libxcmd/input.c > >> index 7a69dc1..7b86225 100644 > >> --- a/libxcmd/input.c > >> +++ b/libxcmd/input.c > >> @@ -330,8 +330,12 @@ cvtnum( > >> c = tolower(*sp); > >> switch (c) { > >> case 'b': > >> + if (!blocksize) > >> + return -1LL; > >> return i * blocksize; > >> case 's': > >> + if (!sectorsize) > >> + return -1LL; > >> return i * sectorsize; > >> case 'k': > >> return KILOBYTES(i); > > > > With this you could have mkfs call the generic function, too. > > Yep, or at least closer; mkfs does a printf and usage()/exit() > and it indicates a user error (most likely) > > in libxcmd/xfs_io it's more of a programming error, with no > printf to the user at least today... so would need a little more > finessing. This series looks mostly fine to me, but I'm wondering if io_cvtnum should be promoted so that mkfs/spaceman/quota/etc can take advantage of it too? --D > > -Eric > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html