Re: [PATCH 5/5] xfs: test fuzzing every field of a dquot

["Darrick J. Wong" <darrick.wong@oracle.com>]

On Thu, Aug 24, 2017 at 05:03:35PM +0800, Eryu Guan wrote:
> On Fri, Jul 21, 2017 at 03:04:58PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> > 
> > See what happens when we fuzz every field of a quota information structure.
> > 
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> 
> These tests all failed in the same way like:
> 
>     +scrub didn't fail with diskdq.magic = zeroes.
>     +scrub didn't fail with diskdq.magic = ones.
>     +scrub didn't fail with diskdq.magic = firstbit.
>     +scrub didn't fail with diskdq.magic = middlebit.
>     ...
> 
> with 4.13-rc5 kernel and xfsprogs for-next branch. I assume that's
> something need to be fixed in the kernel?

Yes, that's testing whether or not online scrub actually notices when
we corrupt something.  I'll look into it, but output like that is a sign
that the test is working as designed. :)

--D

> 
> ...
> 
> > diff --git a/tests/xfs/1382 b/tests/xfs/1382
> > new file mode 100755
> > index 0000000..fd7e50d
> > --- /dev/null
> > +++ b/tests/xfs/1382
> > @@ -0,0 +1,63 @@
> > +#! /bin/bash
> > +# FS QA Test No. 1380
>                     ^^^^ I changed it to 1382 then renumbered.
> 
> Thanks,
> Eryu
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html