From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp1040.oracle.com ([156.151.31.81]:47088 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752071AbdHXRhW (ORCPT ); Thu, 24 Aug 2017 13:37:22 -0400 Date: Thu, 24 Aug 2017 10:37:18 -0700 From: "Darrick J. Wong" Subject: Re: [PATCH 5/5] xfs: test fuzzing every field of a dquot Message-ID: <20170824173718.GG4796@magnolia> References: <150067465981.30639.14801416171688538711.stgit@magnolia> <150067469875.30639.1164952553984333812.stgit@magnolia> <20170824090335.GM31418@eguan.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170824090335.GM31418@eguan.usersys.redhat.com> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Eryu Guan Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org On Thu, Aug 24, 2017 at 05:03:35PM +0800, Eryu Guan wrote: > On Fri, Jul 21, 2017 at 03:04:58PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong > > > > See what happens when we fuzz every field of a quota information structure. > > > > Signed-off-by: Darrick J. Wong > > These tests all failed in the same way like: > > +scrub didn't fail with diskdq.magic = zeroes. > +scrub didn't fail with diskdq.magic = ones. > +scrub didn't fail with diskdq.magic = firstbit. > +scrub didn't fail with diskdq.magic = middlebit. > ... > > with 4.13-rc5 kernel and xfsprogs for-next branch. I assume that's > something need to be fixed in the kernel? Yes, that's testing whether or not online scrub actually notices when we corrupt something. I'll look into it, but output like that is a sign that the test is working as designed. :) --D > > ... > > > diff --git a/tests/xfs/1382 b/tests/xfs/1382 > > new file mode 100755 > > index 0000000..fd7e50d > > --- /dev/null > > +++ b/tests/xfs/1382 > > @@ -0,0 +1,63 @@ > > +#! /bin/bash > > +# FS QA Test No. 1380 > ^^^^ I changed it to 1382 then renumbered. > > Thanks, > Eryu > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html