From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs <linux-xfs@vger.kernel.org>
Subject: [PATCH] xfs_io: clarify the fsmap documentation
Date: Thu, 24 Aug 2017 13:55:55 -0700 [thread overview]
Message-ID: <20170824205555.GI4796@magnolia> (raw)
Explicitly declare that the 'start' and 'end' arguments to fsmap require
one of -d, -l, or -r to select the data, log, or realtime device, and fix
misspelled command name while we're at it.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
io/fsmap.c | 2 ++
man/man8/xfs_io.8 | 7 +++++--
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/io/fsmap.c b/io/fsmap.c
index 9e70c7b..448fb53 100644
--- a/io/fsmap.c
+++ b/io/fsmap.c
@@ -48,6 +48,8 @@ fsmap_help(void)
" -n -- query n extents at a time.\n"
" -m -- output machine-readable format.\n"
" -v -- Verbose information, show AG and offsets. Show flags legend on 2nd -v\n"
+"\n"
+"The optional start and end arguments require one of -d, -l, or -r to be set.\n"
"\n"));
}
diff --git a/man/man8/xfs_io.8 b/man/man8/xfs_io.8
index c87db0b..0082ca9 100644
--- a/man/man8/xfs_io.8
+++ b/man/man8/xfs_io.8
@@ -323,6 +323,9 @@ and
.I end
arguments can be used to constrain the output to a particular range of
disk blocks.
+If these two options are specified, exactly one of
+.BR "-d" ", " "-l" ", or " "-r"
+must also be set.
.RE
.RS 1.0i
.PD 0
@@ -372,12 +375,12 @@ for other filesystem metadata.
.TP
.BI \-n " num_extents"
If this option is given,
-.B xfs_fsmap
+.B fsmap
obtains the extent list of the file in groups of
.I num_extents
extents.
In the absence of
-.BR \-n ", " xfs_fsmap
+.BR "-n" ", " "fsmap"
queries the system for extents in groups of 131,072 records.
.TP
.B \-v
reply other threads:[~2017-08-24 20:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170824205555.GI4796@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).