From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Nikolay Borisov <nborisov@suse.com>,
linux-xfs@vger.kernel.org, sandeen@redhat.com
Subject: Re: [PATCH 7/6] xfs_bmap: fix -n documentation in manpage
Date: Thu, 24 Aug 2017 13:56:47 -0700 [thread overview]
Message-ID: <20170824205647.GJ4796@magnolia> (raw)
In-Reply-To: <5fb3c541-ceaf-409c-3536-96bf8805076c@sandeen.net>
On Thu, Aug 24, 2017 at 03:09:32PM -0500, Eric Sandeen wrote:
> xfs_bmap's manpage mis-describes the behavior from the
> -n option. xfs_io's fiemap command references the xfs_bmap
> manpage, and has the same problem:
>
> -n does not change the query batch size, it limits the number
> of extents displayed.
>
> This has been true for 15+ years, so change the documentation
> to match reality.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
For patches 6 & 7,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
>
> diff --git a/man/man8/xfs_bmap.8 b/man/man8/xfs_bmap.8
> index 098cfae..c725519 100644
> --- a/man/man8/xfs_bmap.8
> +++ b/man/man8/xfs_bmap.8
> @@ -77,12 +77,11 @@ option is used.
> .BI \-n " num_extents"
> If this option is given,
> .B xfs_bmap
> -obtains the extent list of the file in groups of
> +will display at most
> .I num_extents
> extents. In the absence of
> .BR \-n ", " xfs_bmap
> -queries the system for the number of extents in the file and uses that
> -value to compute the group size.
> +will display all extents in the file.
> .TP
> .B \-p
> If this option is used,
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-08-24 20:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 11:47 [PATCH 0/6] Fiemap refactoring Nikolay Borisov
2017-08-24 11:47 ` [PATCH 1/6] fiemap: Remove blocksize variable Nikolay Borisov
2017-08-24 11:47 ` [PATCH 2/6] fiemap: Make max_extents a global var Nikolay Borisov
2017-08-24 11:47 ` [PATCH 3/6] fiemap: Eliminate num_extents Nikolay Borisov
2017-08-24 11:47 ` [PATCH 4/6] fiemap: De-obfuscate last_logical and cur_extent manipulation Nikolay Borisov
2017-08-24 11:47 ` [PATCH 5/6] fiemap: Factor out common code used for printing holes Nikolay Borisov
2017-08-24 11:47 ` [PATCH 6/6] fiemap: Fix semantics of max_extents (-n arguments) Nikolay Borisov
2017-08-24 16:03 ` Eric Sandeen
2017-08-24 16:06 ` Nikolay Borisov
2017-08-24 16:07 ` Eric Sandeen
2017-08-24 17:51 ` Darrick J. Wong
2017-08-24 18:43 ` Eric Sandeen
2017-08-24 20:09 ` [PATCH 7/6] xfs_bmap: fix -n documentation in manpage Eric Sandeen
2017-08-24 20:56 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170824205647.GJ4796@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).