From: Christoph Hellwig <hch@infradead.org>
To: Achilles Gaikwad <achillesgaikwad@gmail.com>
Cc: darrick.wong@oracle.com, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] fs/xfs/kmem.c: fix coding style, using 'unsigned int' instead of 'unsigned'
Date: Fri, 25 Aug 2017 00:45:38 -0700 [thread overview]
Message-ID: <20170825074538.GA26995@infradead.org> (raw)
In-Reply-To: <20170825052659.GA11087@fubar>
On Fri, Aug 25, 2017 at 10:56:59AM +0530, Achilles Gaikwad wrote:
> Fixes a warning given by checkpatch.pl to use 'unsigned int'
> instead of just 'unsigned'.
>
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> + unsigned nofs_flag = 0;
NAK. This is churn for a totally pointless warnings - there is
not quantifiable benefit of 'unsigned int' which unigned has one
clear advantage: it's shorter.
prev parent reply other threads:[~2017-08-25 7:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 5:26 [PATCH] fs/xfs/kmem.c: fix coding style, using 'unsigned int' instead of 'unsigned' Achilles Gaikwad
2017-08-25 7:45 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170825074538.GA26995@infradead.org \
--to=hch@infradead.org \
--cc=achillesgaikwad@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).