* [PATCH] fs/xfs/kmem.c: fix coding style, using 'unsigned int' instead of 'unsigned'
@ 2017-08-25 5:26 Achilles Gaikwad
2017-08-25 7:45 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Achilles Gaikwad @ 2017-08-25 5:26 UTC (permalink / raw)
To: darrick.wong; +Cc: linux-xfs
Fixes a warning given by checkpatch.pl to use 'unsigned int'
instead of just 'unsigned'.
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
+ unsigned nofs_flag = 0;
Signed-off-by: Achilles Gaikwad <achillesgaikwad@gmail.com>
---
fs/xfs/kmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/kmem.c b/fs/xfs/kmem.c
index 393b6849aeb3..a20909087e5e 100644
--- a/fs/xfs/kmem.c
+++ b/fs/xfs/kmem.c
@@ -48,7 +48,7 @@ kmem_alloc(size_t size, xfs_km_flags_t flags)
void *
kmem_zalloc_large(size_t size, xfs_km_flags_t flags)
{
- unsigned nofs_flag = 0;
+ unsigned int nofs_flag = 0;
void *ptr;
gfp_t lflags;
--
2.13.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fs/xfs/kmem.c: fix coding style, using 'unsigned int' instead of 'unsigned'
2017-08-25 5:26 [PATCH] fs/xfs/kmem.c: fix coding style, using 'unsigned int' instead of 'unsigned' Achilles Gaikwad
@ 2017-08-25 7:45 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2017-08-25 7:45 UTC (permalink / raw)
To: Achilles Gaikwad; +Cc: darrick.wong, linux-xfs
On Fri, Aug 25, 2017 at 10:56:59AM +0530, Achilles Gaikwad wrote:
> Fixes a warning given by checkpatch.pl to use 'unsigned int'
> instead of just 'unsigned'.
>
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> + unsigned nofs_flag = 0;
NAK. This is churn for a totally pointless warnings - there is
not quantifiable benefit of 'unsigned int' which unigned has one
clear advantage: it's shorter.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-25 7:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-25 5:26 [PATCH] fs/xfs/kmem.c: fix coding style, using 'unsigned int' instead of 'unsigned' Achilles Gaikwad
2017-08-25 7:45 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).