From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Theodore Ts'o <tytso@mit.edu>,
linux-ext4@vger.kernel.org, Lukas Czerner <lczerner@redhat.com>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH] ext4: introduce per-inode DAX flag
Date: Sat, 26 Aug 2017 09:33:58 +1000 [thread overview]
Message-ID: <20170825233358.GC17782@dastard> (raw)
In-Reply-To: <20170825154032.GA1827@infradead.org>
On Fri, Aug 25, 2017 at 08:40:32AM -0700, Christoph Hellwig wrote:
> On Fri, Aug 25, 2017 at 11:14:45AM -0400, Theodore Ts'o wrote:
> > > I don't know of anyone that actually uses the flag. If someone did
> > > that would probably run into problems like changing that changing it
> > > on a file that's currently mmaped would crash an burn badly.
> >
> > Crash and burn meaning the *kernel* will crash and burn? Or will data
> > be damaged?
> >
> > Given that, maybe XFS should withdraw support for the DAX and hope no
> > one is actually using it?
>
> Nah, -o dax works very well. It's just the flag instead of the -o dax
> option or rather switching it on a mapped file will probably be very dangerous.
In what way is it dangerous, Christoph?
Changing to/form DAX is simply a case of syncing the data and then
invalidating the existing mappings and letting the new faults go
direct or through the page cache. The mapping invalidation
requirements are no different to what we need to do to punch a hole
in a mapped file...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2017-08-25 23:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1501690186-17607-1-git-send-email-lczerner@redhat.com>
[not found] ` <20170805084601.GA12425@infradead.org>
[not found] ` <20170807121212.nuiho4afmdjf5vsd@rh_laptop>
[not found] ` <20170808090016.lxfbcrhoybmyfvlc@rh_laptop>
[not found] ` <20170811100147.GB7064@infradead.org>
[not found] ` <20170811121132.bj5y77scrvkgy7uo@rh_laptop>
[not found] ` <20170811125849.GA15300@infradead.org>
[not found] ` <20170811134130.o46y5jpekrpj5qvw@rh_laptop>
[not found] ` <20170824182057.amdirlrbugezrahy@thunk.org>
2017-08-25 7:54 ` [PATCH] ext4: introduce per-inode DAX flag Christoph Hellwig
2017-08-25 15:14 ` Theodore Ts'o
2017-08-25 15:40 ` Christoph Hellwig
2017-08-25 16:28 ` Theodore Ts'o
2017-08-25 23:33 ` Dave Chinner [this message]
2017-08-28 7:38 ` Christoph Hellwig
2017-08-28 10:10 ` Dave Chinner
2017-08-29 15:49 ` Jan Kara
2017-08-29 22:57 ` Dave Chinner
2017-08-30 10:00 ` Jan Kara
2017-08-30 12:34 ` Christoph Hellwig
2017-08-30 15:00 ` Theodore Ts'o
2017-08-30 15:30 ` Lukas Czerner
2017-08-30 15:29 ` Jan Kara
2017-08-30 16:05 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170825233358.GC17782@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).