linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org, David Windsor <dave@nullcore.net>,
	"Darrick J. Wong" <darrick.wong@oracle.com>,
	linux-xfs@vger.kernel.org, linux-mm@kvack.org,
	kernel-hardening@lists.openwall.com
Subject: Re: [PATCH v2 15/30] xfs: Define usercopy region in xfs_inode slab cache
Date: Tue, 29 Aug 2017 01:14:53 -0700	[thread overview]
Message-ID: <20170829081453.GA10196@infradead.org> (raw)
In-Reply-To: <1503956111-36652-16-git-send-email-keescook@chromium.org>

One thing I've been wondering is wether we should actually just
get rid of the online area.  Compared to reading an inode from
disk a single additional kmalloc is negligible, and not having the
inline data / extent list would allow us to reduce the inode size
significantly.

Kees/David:  how many of these patches are file systems with some
sort of inline data?  Given that it's only about 30 patches declaring
allocations either entirely valid for user copy or not might end up
being nicer in many ways than these offsets.

  parent reply	other threads:[~2017-08-29  8:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1503956111-36652-1-git-send-email-keescook@chromium.org>
2017-08-28 21:34 ` [PATCH v2 15/30] xfs: Define usercopy region in xfs_inode slab cache Kees Cook
2017-08-28 21:49   ` Darrick J. Wong
2017-08-28 21:57     ` Kees Cook
2017-08-29  4:47       ` Darrick J. Wong
2017-08-29 18:48         ` Kees Cook
2017-08-29 19:00           ` Darrick J. Wong
2017-08-29 22:15           ` Dave Chinner
2017-08-29 22:25             ` Kees Cook
2017-08-29  8:14   ` Christoph Hellwig [this message]
2017-08-29 12:31     ` Dave Chinner
2017-08-29 12:45       ` Christoph Hellwig
2017-08-29 21:51         ` Dave Chinner
2017-08-30  7:14           ` Christoph Hellwig
2017-08-30  8:05             ` Dave Chinner
2017-08-30  8:33               ` Christoph Hellwig
2017-08-29 18:55     ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170829081453.GA10196@infradead.org \
    --to=hch@infradead.org \
    --cc=darrick.wong@oracle.com \
    --cc=dave@nullcore.net \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).