linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: linux-xfs@vger.kernel.org
Subject: [PATCH] xfs: remove experimental tag for reflinks
Date: Wed, 30 Aug 2017 16:54:00 +0200	[thread overview]
Message-ID: <20170830145400.3681-1-hch@lst.de> (raw)

But reject reflink + DAX file systems for now until the code to
support reflinks on DAX is actually implemented.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/xfs/xfs_super.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index 38aaacdbb8b3..92521032468e 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -1634,7 +1634,9 @@ xfs_fs_fill_super(
 		}
 		if (xfs_sb_version_hasreflink(&mp->m_sb))
 			xfs_alert(mp,
-		"DAX and reflink have not been tested together!");
+		"DAX and reflink can not be used together!");
+			error = -EINVAL;
+			goto out_filestream_unmount;
 	}
 
 	if (xfs_sb_version_hasrmapbt(&mp->m_sb)) {
@@ -1648,10 +1650,6 @@ xfs_fs_fill_super(
 	"EXPERIMENTAL reverse mapping btree feature enabled. Use at your own risk!");
 	}
 
-	if (xfs_sb_version_hasreflink(&mp->m_sb))
-		xfs_alert(mp,
-	"EXPERIMENTAL reflink feature enabled. Use at your own risk!");
-
 	error = xfs_mountfs(mp);
 	if (error)
 		goto out_filestream_unmount;
-- 
2.11.0


             reply	other threads:[~2017-08-30 14:54 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-30 14:54 Christoph Hellwig [this message]
2017-08-31  6:40 ` [PATCH] xfs: remove experimental tag for reflinks Darrick J. Wong
2017-08-31 12:43   ` Brian Foster
2017-08-31 13:30     ` Christoph Hellwig
2017-08-31 15:31       ` Darrick J. Wong
2017-08-31 15:55         ` Eric Sandeen
2017-08-31 20:02           ` Darrick J. Wong
2017-08-31 15:59         ` Brian Foster
2017-08-31 20:09           ` Darrick J. Wong
2017-08-31 20:36             ` Brian Foster
2017-08-31 22:58               ` Dave Chinner
2017-09-01 11:16                 ` Brian Foster
2017-08-31 22:19   ` Dave Chinner
2018-01-08 21:43     ` Darrick J. Wong
2018-01-08 22:11       ` Dave Chinner
2017-11-15  1:10 ` Darrick J. Wong
2017-11-15  6:14   ` Amir Goldstein
2017-11-22 18:31     ` Darrick J. Wong
2017-11-22 20:40       ` Amir Goldstein
2017-11-22 21:00         ` Darrick J. Wong
2017-11-23 10:44           ` Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170830145400.3681-1-hch@lst.de \
    --to=hch@lst.de \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).