public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Brian Foster <bfoster@redhat.com>
To: Richard Wareing <rwareing@fb.com>
Cc: Dave Chinner <david@fromorbit.com>,
	"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH 1/3] xfs: Add rtdefault mount option
Date: Fri, 1 Sep 2017 15:32:38 -0400	[thread overview]
Message-ID: <20170901193237.GF29225@bfoster.bfoster> (raw)
In-Reply-To: <C6F6823D-65D7-4B73-9AC7-CBA4125F2429@fb.com>

On Fri, Sep 01, 2017 at 06:39:09PM +0000, Richard Wareing wrote:
> Thanks for the quick feedback Dave!  My comments are in-line below.
> 
> 
> > On Aug 31, 2017, at 9:31 PM, Dave Chinner <david@fromorbit.com> wrote:
> > 
> > Hi Richard,
> > 
> > On Thu, Aug 31, 2017 at 06:00:21PM -0700, Richard Wareing wrote:
...
> >> add
> >> support for the more sophisticated AG based block allocator to RT
> >> (bitmapped version works well for us, but multi-threaded use-cases
> >> might not do as well).
> > 
> > That's a great big can of worms - not sure we want to open it. The
> > simplicity of the rt allocator is one of it's major benefits to
> > workloads that require deterministic allocation behaviour...
> 
> Agreed, I took a quick look at what it might take and came to a similar conclusion, but I can dream :).
> 

Just a side point based on the discussion so far... I kind of get the
impression that the primary reason for using realtime support here is
for the simple fact that it's a separate physical device. That provides
a basic mechanism to split files across fast and slow physical storage
based on some up-front heuristic. The fact that the realtime feature
uses a separate allocation algorithm is actually irrelevant (and
possibly a problem in the future).

Is that an accurate assessment? If so, it makes me wonder whether it's
worth thinking about if there are ways to get the same behavior using
traditional functionality. This ignores Dave's question about how much
of the performance actually comes from simply separating out the log,
but for example suppose we had a JBOD block device made up of a
combination of spinning and solid state disks via device-mapper with the
requirement that a boundary from fast -> slow and vice versa was always
at something like a 100GB alignment. Then if you formatted that device
with XFS using 100GB AGs (or whatever to make them line up), and could
somehow tag each AG as "fast" or "slow" based on the known underlying
device mapping, could you potentially get the same results by using the
same heuristics to direct files to particular sets of AGs rather than
between two physical devices? Obviously there are some differences like
metadata being spread across the fast/slow devices (though I think we
had such a thing as metadata only AGs), etc. I'm just handwaving here to
try and better understand the goal.

Brian

> > 
> > Cheers,
> > 
> > Dave.
> > -- 
> > Dave Chinner
> > david@fromorbit.com
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2017-09-01 19:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-01  1:00 [PATCH 1/3] xfs: Add rtdefault mount option Richard Wareing
2017-09-01  4:26 ` Darrick J. Wong
2017-09-01 18:53   ` Richard Wareing
2017-09-01  4:31 ` Dave Chinner
2017-09-01 18:39   ` Richard Wareing
2017-09-01 19:32     ` Brian Foster [this message]
2017-09-01 20:36       ` Richard Wareing
2017-09-01 22:55         ` Dave Chinner
2017-09-01 23:37           ` Richard Wareing
2017-09-02 11:55             ` Brian Foster
2017-09-02 22:56               ` Dave Chinner
2017-09-03  0:43               ` Richard Wareing
2017-09-03  3:31                 ` Richard Wareing
2017-09-04  1:17                 ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170901193237.GF29225@bfoster.bfoster \
    --to=bfoster@redhat.com \
    --cc=david@fromorbit.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=rwareing@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox