From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp1040.oracle.com ([156.151.31.81]:46600 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751715AbdIAUHL (ORCPT ); Fri, 1 Sep 2017 16:07:11 -0400 Date: Fri, 1 Sep 2017 13:06:32 -0700 From: "Darrick J. Wong" Subject: Re: [PATCH v2] xfs: don't set v3 xflags for v2 inodes Message-ID: <20170901200632.GJ3775@magnolia> References: <20170830155517.GI4757@magnolia> <20170830163825.GQ4757@magnolia> <20170831131723.GD19544@infradead.org> <20170831133420.GB21939@bfoster.bfoster> <20170831140932.GB26555@infradead.org> <20170831195729.GM3775@magnolia> <20170901072149.GA7443@infradead.org> <20170901175223.GH3775@magnolia> <20170901192958.GA30923@infradead.org> <20170901194024.GI3775@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170901194024.GI3775@magnolia> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Christoph Hellwig Cc: Brian Foster , xfs , Jan Kara On Fri, Sep 01, 2017 at 12:40:24PM -0700, Darrick J. Wong wrote: > On Fri, Sep 01, 2017 at 12:29:58PM -0700, Christoph Hellwig wrote: > > On Fri, Sep 01, 2017 at 10:52:23AM -0700, Darrick J. Wong wrote: > > > > { > > > > - unsigned int di_flags; > > > > - uint64_t di_flags2; > > > > - > > > > /* can't set PREALLOC this way, just preserve it */ > > > > - di_flags = (ip->i_d.di_flags & XFS_DIFLAG_PREALLOC); > > > > + unsigned int di_flags = > > > > + (ip->i_d.di_flags & XFS_DIFLAG_PREALLOC); > > > > > > ip->i_d.di_flags is uint16_t, so di_flags ought to match, right? > > > > The existing code uses unsigned int as seen above. But yes, it > > could be fixed to be a uint16_t. > > > > > Otherwise, I guess this looks ok, want to send it as a real patch? > > > > Sure. Doing some quick QA runs and it will be out. > > > > Note that I'll assume it'll be for a tree without the previous > > patch, unlike current for-next.. > > Yeah, I'll rebase that whole mess... ...also, I assume you already fixed up: - di_flags2 = xfs_flags2diflags(ip, fa->fsx_xflags); + di_flags2 = xfs_flags2diflags2(ip, fa->fsx_xflags); ? --D > > --D > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html