Re: [PATCH v3] xfs: open code end_buffer_async_write in xfs_finish_page_writeback

[Christoph Hellwig <hch@lst.de>]

On Wed, Aug 16, 2017 at 08:44:54AM -0700, Darrick J. Wong wrote:
> On Wed, Aug 16, 2017 at 10:51:57AM +0200, Christoph Hellwig wrote:
> > Our loop in xfs_finish_page_writeback, which iterates over all buffer
> > heads in a page and then calls end_buffer_async_write, which also
> > iterates over all buffers in the page to check if any I/O is in flight
> > is not only inefficient, but also potentially dangerous as
> > end_buffer_async_write can cause the page and all buffers to be freed.
> > 
> > Replace it with a single loop that does the work of end_buffer_async_write
> > on a per-page basis.
> > 
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Looks ok,
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> 
> I'm assuming 4.14 for this one, unless you know of people banging into
> use-after-free problems and therefore need it pushed into 4.13?

Looks like it didn't make it into for-next for 4.14 either.