From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Khem Raj <raj.khem@gmail.com>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] Rename progname as it is provided by libc
Date: Sun, 3 Sep 2017 00:48:28 -0700 [thread overview]
Message-ID: <20170903074828.GC8351@infradead.org> (raw)
In-Reply-To: <20170902222003.GD10621@dastard>
On Sun, Sep 03, 2017 at 08:20:03AM +1000, Dave Chinner wrote:
> On Sat, Sep 02, 2017 at 02:54:51PM -0700, Khem Raj wrote:
> > Rename local variable progname to avoid a clash with libc
> > global symbols
>
> What libc is causing this problem?
>
> And why is it considered ok for that libc to pollute the global
> variable namespace with it's own internal variables?
I don't think it's libc. It's our own little mess where we
want to set a global progname for libxfs use in the tools.
The right interface is to have a private libxfs_progname routine
that isn't accessible by the tools..
next prev parent reply other threads:[~2017-09-03 7:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-02 21:54 [PATCH] Rename progname as it is provided by libc Khem Raj
2017-09-02 22:20 ` Dave Chinner
2017-09-02 23:42 ` Khem Raj
2017-09-03 7:21 ` Khem Raj
2017-09-03 7:48 ` Christoph Hellwig [this message]
2017-09-08 16:25 ` Eric Sandeen
2017-09-08 16:29 ` Khem Raj
2017-09-08 18:13 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170903074828.GC8351@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox