From: Christoph Hellwig <hch@lst.de>
To: Eryu Guan <eguan@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: test the per-inode DAX flag
Date: Mon, 4 Sep 2017 17:44:53 +0200 [thread overview]
Message-ID: <20170904154453.GA6771@lst.de> (raw)
In-Reply-To: <20170904072431.GW27835@eguan.usersys.redhat.com>
On Mon, Sep 04, 2017 at 03:24:31PM +0800, Eryu Guan wrote:
> On Sun, Sep 03, 2017 at 11:33:25AM +0200, Christoph Hellwig wrote:
> > This tests checks that the per-inode DAX flag is either reject
> > or sticks around, and that rapidly setting/clearing it will not
> > crash the kernel.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Does this test make sense when filesystem was mounted without dax
> option? I saw these failures when testing on normal block device without
> dax mount option.
I think the first part that tries to set it makes sense everywhere,
but we should also _notrun for this case and not just for EINVAL.
That being said: right now I don't understand at all where the
EIO when setting the flag comes from, let me figure out where it is.
And thinking about it - why would we not allow setting the flag,
especially given that right now it doesn't have a meaning either
with or without DAX..
next prev parent reply other threads:[~2017-09-04 15:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-03 9:33 test the per-inode DAX flag Christoph Hellwig
2017-09-04 7:24 ` Eryu Guan
2017-09-04 15:44 ` Christoph Hellwig [this message]
2017-09-06 14:50 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170904154453.GA6771@lst.de \
--to=hch@lst.de \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox