From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Amir Goldstein <amir73il@gmail.com>, Eryu Guan <eguan@redhat.com>,
fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [RFC][PATCH] fstests: regression test for xfs leftover CoW extent error
Date: Mon, 4 Sep 2017 08:46:35 -0700 [thread overview]
Message-ID: <20170904154635.GF4671@magnolia> (raw)
In-Reply-To: <20170904153026.GA6469@lst.de>
On Mon, Sep 04, 2017 at 05:30:26PM +0200, Christoph Hellwig wrote:
> On Sun, Sep 03, 2017 at 02:04:27PM -0700, Darrick J. Wong wrote:
> > On Sun, Sep 03, 2017 at 08:21:33PM +0200, Christoph Hellwig wrote:
> > > > So basically there are two bugs here -- the fcollapse/finsert code needs
> > > > to shift the CoW fork extents down and up;
> > >
> > > Or make sure that we don't have any extents in the COW fork?
> >
> > It's a big hammer approach, but yes that'd work.
> >
> > We're already forcing all the dirty pages out anyway so I guess it's no
> > big deal.
>
> It might be a big deal for my O_ATOMIC work, but I'll need to need
> to find that work and actually define semantics vs nasty operations
> like insert and swapext for that.
>
> Then again shifting the cow forks seems relatively easy - we'd just
> need to look at the whichfork argument in the low-level helpers
> basically.
Yes, it looks pretty straightforward. I'll send my dumb version that
merely evicts everything from the cow fork to the list and see if that
motivates anyone to try their hand at shifting the cow fork.
> > > > /*
> > > > * Clear the reflink flag if we truncated everything.
> > > > */
> > > > - if (ip->i_d.di_nblocks == 0 && xfs_is_reflink_inode(ip)) {
> > > > + if (ip->i_d.di_nblocks == 0 && ip->i_cnextents == 0 && xfs_is_reflink_inode(ip)) {
> > >
> > > Btw, it seems like we should generally clear the reflink flag and
> > > tag if ip->i_cnextents is zero and not even bother looking at di_nblocks.
> >
> > We can't -- imagine shortening to 8k a reflinked 12k file that hasn't been
> > written to. It has no cow extents, but we cannot drop the reflink flag.
>
> True for the reflink flag. But we should be able to clear the cowblocks
> tag whenever i_cnextents reaches zero.
<nod> I was about to send out a cleaner patch.
--D
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-09-04 15:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-03 15:07 [RFC][PATCH] fstests: regression test for xfs leftover CoW extent error Amir Goldstein
2017-09-03 17:45 ` Darrick J. Wong
2017-09-03 18:21 ` Christoph Hellwig
2017-09-03 21:04 ` Darrick J. Wong
2017-09-04 7:31 ` Amir Goldstein
2017-09-04 15:30 ` Christoph Hellwig
2017-09-04 15:46 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170904154635.GF4671@magnolia \
--to=darrick.wong@oracle.com \
--cc=amir73il@gmail.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).