From: Chandan Rajendra <chandan@linux.vnet.ibm.com>
To: linux-xfs@vger.kernel.org, sandeen@sandeen.net
Cc: Chandan Rajendra <chandan@linux.vnet.ibm.com>
Subject: [PATCH] mkfs: Remove messages printed when blocksize < physical sectorsize
Date: Tue, 5 Sep 2017 11:14:42 +0530 [thread overview]
Message-ID: <20170905054442.28615-1-chandan@linux.vnet.ibm.com> (raw)
Linux kernel commit 6c6b6f28b3335fd85ec833ee0005d9c9dca6c003 (loop: set
physical block size to PAGE_SIZE) now sets PAGE_SIZE as the default
physical sector size of loop devices. On ppc64, this causes loop devices
to have 64k as the physical sector size.
With these changes, mkfs.xfs now prints error messages when filesystem
blocksize (4k) is less than underlying device's physical
sectorsize (64k). These messages (printed on stderr) now cause several
xfstests to fail on ppc64 machine since xfstests' _filter_mkfs() isn't
able to filter out stderr.
Also, the messages themselves describe a possible sub-optimal setup. But
the setup is still usable.
Hence this commit removes the calls to fprintf() used to print the
messages.
Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
---
mkfs/xfs_mkfs.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index dfffae7..0bb3897 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -2011,12 +2011,6 @@ _("Minimum block size for CRC enabled filesystems is %d bytes.\n"),
XFS_MIN_SECTORSIZE;
if ((blocksize < sectorsize) && (blocksize >= ft.lsectorsize)) {
- fprintf(stderr,
-_("specified blocksize %d is less than device physical sector size %d\n"),
- blocksize, ft.psectorsize);
- fprintf(stderr,
-_("switching to logical sector size %d\n"),
- ft.lsectorsize);
sectorsize = ft.lsectorsize ? ft.lsectorsize :
XFS_MIN_SECTORSIZE;
}
--
2.9.5
next reply other threads:[~2017-09-05 5:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 5:44 Chandan Rajendra [this message]
2017-09-05 6:31 ` [PATCH] mkfs: Remove messages printed when blocksize < physical sectorsize Christoph Hellwig
2017-09-05 6:42 ` Omar Sandoval
2017-09-05 7:37 ` Chandan Rajendra
2017-09-05 15:00 ` Jens Axboe
2017-09-05 22:06 ` Dave Chinner
2017-09-05 22:18 ` Omar Sandoval
2017-09-05 23:24 ` Dave Chinner
2017-09-06 0:01 ` Omar Sandoval
2017-09-05 6:44 ` Dave Chinner
2017-09-05 14:17 ` Eric Sandeen
2017-09-05 22:10 ` Dave Chinner
2017-09-05 22:16 ` Eric Sandeen
2017-09-08 16:55 ` Eric Sandeen
2017-09-09 6:41 ` Chandan Rajendra
2017-09-09 7:06 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170905054442.28615-1-chandan@linux.vnet.ibm.com \
--to=chandan@linux.vnet.ibm.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox