From: Dave Chinner <david@fromorbit.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] spaceman: Add missing link to libuuid
Date: Thu, 7 Sep 2017 12:40:17 +1000 [thread overview]
Message-ID: <20170907024017.GX17782@dastard> (raw)
In-Reply-To: <20170907021900.41040-1-raj.khem@gmail.com>
On Wed, Sep 06, 2017 at 07:19:00PM -0700, Khem Raj wrote:
> When uuid is enabled then we see linking failures with gold linker e.g.
>
> libxfs/.libs/libxfs.so: error: undefined reference to 'uuid_compare'
> libxfs/.libs/libxfs.so: error: undefined reference to 'uuid_copy'
> clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)
That's libxfs, not xfs_spaceman....
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> spaceman/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/spaceman/Makefile b/spaceman/Makefile
> index 95ec3c0..060e0af 100644
> --- a/spaceman/Makefile
> +++ b/spaceman/Makefile
> @@ -9,7 +9,7 @@ LTCOMMAND = xfs_spaceman
> HFILES = init.h space.h
> CFILES = init.c file.c prealloc.c trim.c
>
> -LLDLIBS = $(LIBXCMD)
> +LLDLIBS = $(LIBXCMD) $(LIBUUID)
And spaceman doesn't link against libxfs, nor does libxcmd or
spaceman use uuids so I don't see why this fixes a problem with
libxfs...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2017-09-07 2:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 2:19 [PATCH] spaceman: Add missing link to libuuid Khem Raj
2017-09-07 2:40 ` Dave Chinner [this message]
2017-09-07 4:11 ` Khem Raj
2017-09-07 6:59 ` Dave Chinner
2017-09-08 18:24 ` Khem Raj
2017-09-08 19:15 ` Eric Sandeen
2017-09-08 20:38 ` Khem Raj
2017-09-08 22:36 ` Dave Chinner
2017-09-08 23:22 ` Khem Raj
2017-09-09 0:33 ` Eric Sandeen
2017-09-09 0:36 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170907024017.GX17782@dastard \
--to=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox