From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ipmail06.adl6.internode.on.net ([150.101.137.145]:25443 "EHLO ipmail06.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751538AbdIGCkU (ORCPT ); Wed, 6 Sep 2017 22:40:20 -0400 Date: Thu, 7 Sep 2017 12:40:17 +1000 From: Dave Chinner Subject: Re: [PATCH] spaceman: Add missing link to libuuid Message-ID: <20170907024017.GX17782@dastard> References: <20170907021900.41040-1-raj.khem@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170907021900.41040-1-raj.khem@gmail.com> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Khem Raj Cc: linux-xfs@vger.kernel.org On Wed, Sep 06, 2017 at 07:19:00PM -0700, Khem Raj wrote: > When uuid is enabled then we see linking failures with gold linker e.g. > > libxfs/.libs/libxfs.so: error: undefined reference to 'uuid_compare' > libxfs/.libs/libxfs.so: error: undefined reference to 'uuid_copy' > clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation) That's libxfs, not xfs_spaceman.... > > Signed-off-by: Khem Raj > --- > spaceman/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/spaceman/Makefile b/spaceman/Makefile > index 95ec3c0..060e0af 100644 > --- a/spaceman/Makefile > +++ b/spaceman/Makefile > @@ -9,7 +9,7 @@ LTCOMMAND = xfs_spaceman > HFILES = init.h space.h > CFILES = init.c file.c prealloc.c trim.c > > -LLDLIBS = $(LIBXCMD) > +LLDLIBS = $(LIBXCMD) $(LIBUUID) And spaceman doesn't link against libxfs, nor does libxcmd or spaceman use uuids so I don't see why this fixes a problem with libxfs... Cheers, Dave. -- Dave Chinner david@fromorbit.com