From: Dave Chinner <david@fromorbit.com>
To: Hou Tao <houtao1@huawei.com>
Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>,
linux-xfs@vger.kernel.org, darrick.wong@oracle.com
Subject: Re: [PATCH v3] xfs: add online uevent for mount operation
Date: Fri, 8 Sep 2017 10:49:05 +1000 [thread overview]
Message-ID: <20170908004905.GE17782@dastard> (raw)
In-Reply-To: <8d432f76-4973-7cdd-280b-3c6d541416fd@huawei.com>
On Thu, Sep 07, 2017 at 04:56:56PM +0800, Hou Tao wrote:
> > Note that kobject_uevent_env() can also fail during
> > netlink_broadcast_filtered(), so perhaps we should consider all errors well
> > here.
> Yes, to deliver the uevent reliably we need to handle the error returned by
> kobject_uevent_evn(), and abort the filesystem mount if any error occurs.
Failing to delivery a mount uevent is not a fatal error. An
inconvenience, yes, but it does not prevent the filesystem from
operating. We do not consider errors when other user events we push to
userspace through netlink fail (e.g. quota warnings), so I don't see
why we should treat this any differently, especially as a user can
still configure the filesystem as they need without the mount
uevent...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2017-09-08 0:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 6:50 [PATCH v3] xfs: add online uevent for mount operation Hou Tao
2017-09-06 0:52 ` Luis R. Rodriguez
2017-09-07 8:56 ` Hou Tao
2017-09-08 0:49 ` Dave Chinner [this message]
2017-09-18 18:00 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170908004905.GE17782@dastard \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=houtao1@huawei.com \
--cc=linux-xfs@vger.kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).