From: Christoph Hellwig <hch@lst.de>
To: Brian Foster <bfoster@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 07/17] xfs: use the proper state defines in xfs_bmap_del_extent_real
Date: Fri, 8 Sep 2017 09:33:24 +0200 [thread overview]
Message-ID: <20170908073324.GA25065@lst.de> (raw)
In-Reply-To: <20170907154708.GG61662@bfoster.bfoster>
On Thu, Sep 07, 2017 at 11:47:09AM -0400, Brian Foster wrote:
> The code looks correct because the states ultimately map to the correct
> logic, but I think this is actually a misuse of the bmap states. The
> contig states are used to define left and right extent contiguity. Here
> (and in del_extent_[delay|cow]()) we use them to track extent
> replacement alignment, which should be represented by the left and right
> filling states (as is done for delalloc/unwritten conversion helpers).
> Perhaps we should fix that all up?
Sure, will do when reposting.
next prev parent reply other threads:[~2017-09-08 7:33 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-03 7:29 refactor extent manipulation Christoph Hellwig
2017-09-03 7:29 ` [PATCH 01/17] xfs: fix incorrect extent state in xfs_bmap_add_extent_unwritten_real Christoph Hellwig
2017-09-07 15:46 ` Brian Foster
2017-09-03 7:29 ` [PATCH 02/17] xfs: use xfs_iext_get_extent instead of open coding it Christoph Hellwig
2017-09-07 15:46 ` Brian Foster
2017-09-03 7:29 ` [PATCH 03/17] xfs: don't set XFS_BTCUR_BPRV_WASDEL in xfs_bunmapi Christoph Hellwig
2017-09-07 15:46 ` Brian Foster
2017-09-03 7:29 ` [PATCH 04/17] xfs: rename bno to end in __xfs_bunmapi Christoph Hellwig
2017-09-07 15:46 ` Brian Foster
2017-09-03 7:29 ` [PATCH 05/17] xfs: use xfs_bmap_del_extent_delay for the data fork as well Christoph Hellwig
2017-09-07 15:46 ` Brian Foster
2017-09-03 7:29 ` [PATCH 06/17] xfs: move some more code into xfs_bmap_del_extent_real Christoph Hellwig
2017-09-07 15:47 ` Brian Foster
2017-09-03 7:29 ` [PATCH 07/17] xfs: use the proper state defines in xfs_bmap_del_extent_real Christoph Hellwig
2017-09-07 15:47 ` Brian Foster
2017-09-08 7:33 ` Christoph Hellwig [this message]
2017-09-03 7:29 ` [PATCH 08/17] xfs: refactor xfs_del_extent_real Christoph Hellwig
2017-09-07 20:21 ` Brian Foster
2017-09-03 7:29 ` [PATCH 09/17] xfs: refactor xfs_bmap_add_extent_hole_delay Christoph Hellwig
2017-09-07 20:21 ` Brian Foster
2017-09-03 7:29 ` [PATCH 10/17] xfs: refactor xfs_bmap_add_extent_hole_real Christoph Hellwig
2017-09-07 20:21 ` Brian Foster
2017-09-03 7:29 ` [PATCH 11/17] xfs: refactor xfs_bmap_add_extent_delay_real Christoph Hellwig
2017-09-08 17:18 ` Brian Foster
2017-09-14 13:23 ` Christoph Hellwig
2017-09-03 7:29 ` [PATCH 12/17] xfs: refactor xfs_bmap_add_extent_unwritten_real Christoph Hellwig
2017-09-08 17:19 ` Brian Foster
2017-09-03 7:29 ` [PATCH 13/17] xfs: pass a struct xfs_bmbt_irec to xfs_bmbt_update Christoph Hellwig
2017-09-08 17:19 ` Brian Foster
2017-09-03 7:29 ` [PATCH 14/17] xfs: pass a struct xfs_bmbt_irec to xfs_bmbt_lookup_eq Christoph Hellwig
2017-09-08 17:19 ` Brian Foster
2017-09-03 7:29 ` [PATCH 15/17] xfs: replace xfs_bmbt_lookup_ge with xfs_bmbt_lookup_first Christoph Hellwig
2017-09-08 17:19 ` Brian Foster
2017-09-03 7:29 ` [PATCH 16/17] xfs: remove all xfs_bmbt_set_* helpers except for xfs_bmbt_set_all Christoph Hellwig
2017-09-08 17:19 ` Brian Foster
2017-09-03 7:29 ` [PATCH 17/17] xfs: remove xfs_bmbt_get_state Christoph Hellwig
2017-09-08 17:19 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170908073324.GA25065@lst.de \
--to=hch@lst.de \
--cc=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox