From: Christoph Hellwig <hch@infradead.org>
To: Eryu Guan <eguan@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs: report zeroed or not correctly in xfs_zero_range()
Date: Fri, 8 Sep 2017 00:37:17 -0700 [thread overview]
Message-ID: <20170908073717.GB26110@infradead.org> (raw)
In-Reply-To: <20170907034254.7180-1-eguan@redhat.com>
On Thu, Sep 07, 2017 at 11:42:53AM +0800, Eryu Guan wrote:
> The 'did_zero' param of xfs_zero_range() was not passed to
> iomap_zero_range() correctly. This was introduced by commit
> 7bb41db3ea16 ("xfs: handle 64-bit length in xfs_iozero"), and found
> by code inspection.
Looks good. Although this makes me wonder why we pass the
argument at all, given that it doesn't seem to matter :)
Joking aside: xfs_setattr_size seems to care to write out
the buffer cache zeroed byes, so this looks good to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2017-09-08 7:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 3:42 [PATCH 1/2] xfs: report zeroed or not correctly in xfs_zero_range() Eryu Guan
2017-09-07 3:42 ` [PATCH 2/2] xfs: kill meaningless variable 'zero' Eryu Guan
2017-09-07 9:05 ` Carlos Maiolino
2017-09-08 7:37 ` Christoph Hellwig
2017-09-07 8:49 ` [PATCH 1/2] xfs: report zeroed or not correctly in xfs_zero_range() Carlos Maiolino
2017-09-08 7:37 ` Christoph Hellwig [this message]
2017-09-18 18:40 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170908073717.GB26110@infradead.org \
--to=hch@infradead.org \
--cc=eguan@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).