From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
linux-kernel@vger.kernel.org, Jan Kara <jack@suse.cz>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
linux-nvdimm@lists.01.org, Dave Chinner <david@fromorbit.com>,
stable@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs: always use DAX if mount option is used
Date: Fri, 8 Sep 2017 09:28:05 -0600 [thread overview]
Message-ID: <20170908152805.GA16646@linux.intel.com> (raw)
In-Reply-To: <20170908072027.GA27725@infradead.org>
On Fri, Sep 08, 2017 at 12:20:28AM -0700, Christoph Hellwig wrote:
> On Thu, Sep 07, 2017 at 03:08:31PM -0600, Ross Zwisler wrote:
> > Before support for the per-inode DAX flag was disabled the XFS the code had
> > an issue where the user couldn't reliably tell whether or not DAX was being
> > used to service page faults and I/O when the DAX mount option was used. In
> > this case each inode within the mounted filesystem started with S_DAX set
> > due to the mount option, but it could be cleared if someone touched the
> > individual inode flag.
>
> Looks good, but can you please add a testcase to xfstests for this?
Hmm...aside from looking at tracepoints, I'm not sure how to detect whether or
not S_DAX is actually being used for an inode. I don't see any other xfstests
that try and look at the trace buffer, but I guess that could work.
Do you know of a better way to detect this test failure/success?
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks for the review!
next prev parent reply other threads:[~2017-09-08 15:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 21:08 [PATCH 0/2] xfs: some DAX fixes Ross Zwisler
2017-09-07 21:08 ` [PATCH 1/2] xfs: always use DAX if mount option is used Ross Zwisler
2017-09-08 7:20 ` Christoph Hellwig
2017-09-08 15:28 ` Ross Zwisler [this message]
2017-09-08 21:21 ` [PATCH] xfs: add regression test for DAX mount option usage Ross Zwisler
2017-09-11 15:16 ` Ross Zwisler
2017-09-11 15:37 ` Dan Williams
2017-09-11 20:01 ` [fstests PATCH v2] " Ross Zwisler
2017-09-14 6:57 ` Eryu Guan
2017-09-15 22:42 ` Ross Zwisler
2017-09-16 22:26 ` Dave Chinner
2017-09-12 6:44 ` [PATCH] " Dave Chinner
2017-09-12 15:38 ` Ross Zwisler
2017-09-12 23:47 ` Dave Chinner
2017-09-13 14:42 ` Ross Zwisler
2017-09-13 22:01 ` Dave Chinner
2017-09-13 22:23 ` Dan Williams
2017-09-13 23:34 ` Dave Chinner
2017-09-14 0:28 ` Dan Williams
2017-09-14 0:40 ` Dave Chinner
2017-09-14 1:24 ` Dan Williams
2017-09-14 12:19 ` Jeff Moyer
2017-09-14 13:16 ` Johannes Thumshirn
2017-09-14 14:10 ` Dan Williams
2017-09-15 9:18 ` Johannes Thumshirn
2017-09-15 17:39 ` Dan Williams
2017-09-18 7:47 ` Johannes Thumshirn
2017-09-07 21:08 ` [PATCH 2/2] xfs: validate bdev support for DAX inode flag Ross Zwisler
2017-09-08 7:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170908152805.GA16646@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).