From: Christoph Hellwig <hch@infradead.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Dave Chinner <david@fromorbit.com>,
Dave Jones <davej@codemonkey.org.uk>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
linux-xfs@vger.kernel.org
Subject: Re: iov_iter_pipe warning.
Date: Mon, 11 Sep 2017 05:07:57 -0700 [thread overview]
Message-ID: <20170911120757.GA29476@infradead.org> (raw)
In-Reply-To: <20170910230723.GG5426@ZenIV.linux.org.uk>
On Mon, Sep 11, 2017 at 12:07:23AM +0100, Al Viro wrote:
> BTW, another problem I see there is that iomap_dio_actor() should *NOT*
> assume that do-while loop in there will always manage to shove 'length'
> bytes out in case of success. That is simply not true for pipe-backed
> destination. And I'm not sure if outright failures halfway through
> are handled correctly. What does it need a copy of dio->submit.iter for,
> anyway? Why not work with dio->submit.iter directly?
> --
So that we only walk the pagetables and pin down the pages that
we can actually use in this iteration.
next prev parent reply other threads:[~2017-09-11 12:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170412152600.GP29622@ZenIV.linux.org.uk>
[not found] ` <20170412162709.bn5qfk4seues3yos@codemonkey.org.uk>
[not found] ` <20170412170723.GQ29622@ZenIV.linux.org.uk>
[not found] ` <20170412190318.srkkdytf2ebrjzrg@codemonkey.org.uk>
[not found] ` <20170421175430.GT29622@ZenIV.linux.org.uk>
[not found] ` <20170428152955.mafs3f22srmm34aw@codemonkey.org.uk>
[not found] ` <20170428164313.GK29622@ZenIV.linux.org.uk>
[not found] ` <20170428165024.ofyl2atpjwohekqa@codemonkey.org.uk>
[not found] ` <20170428172024.GL29622@ZenIV.linux.org.uk>
[not found] ` <20170807201818.kykqzexce6ap6aik@codemonkey.org.uk>
2017-08-28 20:31 ` iov_iter_pipe warning Dave Jones
2017-08-29 4:25 ` Darrick J. Wong
2017-08-30 17:05 ` Dave Jones
2017-08-30 17:13 ` Darrick J. Wong
2017-08-30 17:17 ` Dave Jones
2017-09-06 20:03 ` Dave Jones
2017-09-06 23:46 ` Dave Chinner
2017-09-07 3:48 ` Dave Jones
2017-09-07 4:33 ` Al Viro
2017-09-08 1:04 ` Al Viro
2017-09-10 1:07 ` Dave Jones
2017-09-10 2:57 ` Al Viro
2017-09-10 16:07 ` Dave Jones
2017-09-10 20:05 ` Al Viro
2017-09-10 20:07 ` Dave Jones
2017-09-10 20:33 ` Al Viro
2017-09-10 21:11 ` Dave Chinner
2017-09-10 21:19 ` Al Viro
2017-09-10 22:08 ` Dave Chinner
2017-09-10 23:07 ` Al Viro
2017-09-10 23:15 ` Al Viro
2017-09-11 0:31 ` Dave Chinner
2017-09-11 3:32 ` Al Viro
2017-09-11 6:44 ` Dave Chinner
2017-09-11 20:07 ` Al Viro
2017-09-11 20:17 ` Al Viro
2017-09-12 6:02 ` Dave Chinner
2017-09-12 11:13 ` Al Viro
2017-09-11 12:07 ` Christoph Hellwig [this message]
2017-09-11 12:51 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170911120757.GA29476@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=davej@codemonkey.org.uk \
--cc=david@fromorbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).