From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
fstests@vger.kernel.org, Eryu Guan <eguan@redhat.com>,
Jan Kara <jack@suse.cz>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
linux-nvdimm@lists.01.org, Christoph Hellwig <hch@lst.de>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: add regression test for DAX mount option usage
Date: Wed, 13 Sep 2017 08:42:15 -0600 [thread overview]
Message-ID: <20170913144215.GA12395@linux.intel.com> (raw)
In-Reply-To: <20170912234729.GW10621@dastard>
On Wed, Sep 13, 2017 at 09:47:29AM +1000, Dave Chinner wrote:
<>
> I think similar concerns exist with using perf, too....
I though that using perf addressed both concerns?
> > > So what happens when the user is already tracing the test to
> > > find a bug and the test turns all their tracing off?
By using perf we isolate our tracing from whatever other tracing is happening
in the system. So, unlike the case where we were messing with a system-wide
ftrace knob, we run perf on our executable, and someone else can run perf on
their executable, and they don't collide.
> > > Regardless of this screwing up developer bug triage, do we really
> > > want to add a dependency on kernel tracing into the test harness?
Yep, you're right that this adds a dependency on perf. But unfortunately,
without using either perf or ftrace, I don't know of a way to detect whether
or not DAX is actually being used. Can you think of another way?
I tried to do this correctly and just skip the test with _notrun if perf isn't
available on the host system. This is the same thing that happens if you are
missing other dependencies for a test (some other command (chacl, getfattr,
setfattr) not present, quota tools not installed, required users not present,
etc).
next prev parent reply other threads:[~2017-09-13 14:42 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 21:08 [PATCH 0/2] xfs: some DAX fixes Ross Zwisler
2017-09-07 21:08 ` [PATCH 1/2] xfs: always use DAX if mount option is used Ross Zwisler
2017-09-08 7:20 ` Christoph Hellwig
2017-09-08 15:28 ` Ross Zwisler
2017-09-08 21:21 ` [PATCH] xfs: add regression test for DAX mount option usage Ross Zwisler
2017-09-11 15:16 ` Ross Zwisler
2017-09-11 15:37 ` Dan Williams
2017-09-11 20:01 ` [fstests PATCH v2] " Ross Zwisler
2017-09-14 6:57 ` Eryu Guan
2017-09-15 22:42 ` Ross Zwisler
2017-09-16 22:26 ` Dave Chinner
2017-09-12 6:44 ` [PATCH] " Dave Chinner
2017-09-12 15:38 ` Ross Zwisler
2017-09-12 23:47 ` Dave Chinner
2017-09-13 14:42 ` Ross Zwisler [this message]
2017-09-13 22:01 ` Dave Chinner
2017-09-13 22:23 ` Dan Williams
2017-09-13 23:34 ` Dave Chinner
2017-09-14 0:28 ` Dan Williams
2017-09-14 0:40 ` Dave Chinner
2017-09-14 1:24 ` Dan Williams
2017-09-14 12:19 ` Jeff Moyer
2017-09-14 13:16 ` Johannes Thumshirn
2017-09-14 14:10 ` Dan Williams
2017-09-15 9:18 ` Johannes Thumshirn
2017-09-15 17:39 ` Dan Williams
2017-09-18 7:47 ` Johannes Thumshirn
2017-09-07 21:08 ` [PATCH 2/2] xfs: validate bdev support for DAX inode flag Ross Zwisler
2017-09-08 7:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170913144215.GA12395@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).