From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Zorro Lang <zlang@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfsprogs/db: version command misses RMAPBT feature string
Date: Mon, 18 Sep 2017 08:38:29 -0700 [thread overview]
Message-ID: <20170918153829.GB6540@magnolia> (raw)
In-Reply-To: <20170918071335.19365-1-zlang@redhat.com>
On Mon, Sep 18, 2017 at 03:13:35PM +0800, Zorro Lang wrote:
> When I create a XFS with "rmapbt=1,reflink=1", "xfs_db -c version"
> didn't show RMAPBT feature. But REFLINK can be found.
>
> # mkfs/mkfs.xfs -f -m rmapbt=1,reflink=1 /dev/sda3
> # db/xfs_db -c version /dev/sda3
> versionnum [0xb4a5+0x18a] = V5,NLINK,DIRV2,ALIGN,LOGV2,EXTFLG,MOREBITS,ATTR2,LAZYSBCOUNT,PROJID32BIT,CRC,FTYPE,FINOBT,REFLINK
>
> Signed-off-by: Zorro Lang <zlang@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> db/sb.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/db/sb.c b/db/sb.c
> index 8e7722cd..01d94a66 100644
> --- a/db/sb.c
> +++ b/db/sb.c
> @@ -694,6 +694,8 @@ version_string(
> strcat(s, ",SPARSE_INODES");
> if (xfs_sb_version_hasmetauuid(sbp))
> strcat(s, ",META_UUID");
> + if (xfs_sb_version_hasrmapbt(sbp))
> + strcat(s, ",RMAPBT");
> if (xfs_sb_version_hasreflink(sbp))
> strcat(s, ",REFLINK");
> return s;
> --
> 2.13.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-09-18 15:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 7:13 [PATCH] xfsprogs/db: version command misses RMAPBT feature string Zorro Lang
2017-09-18 12:44 ` Brian Foster
2017-09-18 15:38 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170918153829.GB6540@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).