From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Hou Tao <houtao1@huawei.com>,
"Luis R. Rodriguez" <mcgrof@kernel.org>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH v3] xfs: add online uevent for mount operation
Date: Mon, 18 Sep 2017 11:00:21 -0700 [thread overview]
Message-ID: <20170918180021.GH6540@magnolia> (raw)
In-Reply-To: <20170908004905.GE17782@dastard>
On Fri, Sep 08, 2017 at 10:49:05AM +1000, Dave Chinner wrote:
> On Thu, Sep 07, 2017 at 04:56:56PM +0800, Hou Tao wrote:
> > > Note that kobject_uevent_env() can also fail during
> > > netlink_broadcast_filtered(), so perhaps we should consider all errors well
> > > here.
> > Yes, to deliver the uevent reliably we need to handle the error returned by
> > kobject_uevent_evn(), and abort the filesystem mount if any error occurs.
>
> Failing to delivery a mount uevent is not a fatal error. An
> inconvenience, yes, but it does not prevent the filesystem from
> operating. We do not consider errors when other user events we push to
> userspace through netlink fail (e.g. quota warnings), so I don't see
> why we should treat this any differently, especially as a user can
> still configure the filesystem as they need without the mount
> uevent...
I agree with Dave that it seems excessive to fail the mount just because
the uevent transmission failed. I don't see any use case where it's
absolutely critical that a configuration knob gets turned.
I would also reiterate that I want to see at least an RFC of the
userland side of this because I'd rather not have to maintain a kernel
feature that is totally unused by upstream userspace.
--D
>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-09-18 18:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 6:50 [PATCH v3] xfs: add online uevent for mount operation Hou Tao
2017-09-06 0:52 ` Luis R. Rodriguez
2017-09-07 8:56 ` Hou Tao
2017-09-08 0:49 ` Dave Chinner
2017-09-18 18:00 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170918180021.GH6540@magnolia \
--to=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=houtao1@huawei.com \
--cc=linux-xfs@vger.kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).