* [PATCH 10/14] fs/xfs: Use %pS printk format for direct addresses
[not found] <1504729681-3504-1-git-send-email-deller@gmx.de>
@ 2017-09-06 20:27 ` Helge Deller
2017-09-08 7:38 ` Christoph Hellwig
2017-09-18 18:37 ` Darrick J. Wong
0 siblings, 2 replies; 3+ messages in thread
From: Helge Deller @ 2017-09-06 20:27 UTC (permalink / raw)
To: linux-kernel
Cc: Sergey Senozhatsky, Petr Mladek, Andrew Morton, Darrick J. Wong,
linux-xfs
Use the %pS instead of the %pF printk format specifier for printing symbols
from direct addresses. This is needed for the ia64, ppc64 and parisc64
architectures.
Signed-off-by: Helge Deller <deller@gmx.de>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
---
fs/xfs/xfs_error.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_error.c b/fs/xfs/xfs_error.c
index 2f4feb9..028e50a 100644
--- a/fs/xfs/xfs_error.c
+++ b/fs/xfs/xfs_error.c
@@ -344,7 +344,7 @@ xfs_verifier_error(
{
struct xfs_mount *mp = bp->b_target->bt_mount;
- xfs_alert(mp, "Metadata %s detected at %pF, %s block 0x%llx",
+ xfs_alert(mp, "Metadata %s detected at %pS, %s block 0x%llx",
bp->b_error == -EFSBADCRC ? "CRC error" : "corruption",
__return_address, bp->b_ops->name, bp->b_bn);
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 10/14] fs/xfs: Use %pS printk format for direct addresses
2017-09-06 20:27 ` [PATCH 10/14] fs/xfs: Use %pS printk format for direct addresses Helge Deller
@ 2017-09-08 7:38 ` Christoph Hellwig
2017-09-18 18:37 ` Darrick J. Wong
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2017-09-08 7:38 UTC (permalink / raw)
To: Helge Deller
Cc: linux-kernel, Sergey Senozhatsky, Petr Mladek, Andrew Morton,
Darrick J. Wong, linux-xfs
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 10/14] fs/xfs: Use %pS printk format for direct addresses
2017-09-06 20:27 ` [PATCH 10/14] fs/xfs: Use %pS printk format for direct addresses Helge Deller
2017-09-08 7:38 ` Christoph Hellwig
@ 2017-09-18 18:37 ` Darrick J. Wong
1 sibling, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2017-09-18 18:37 UTC (permalink / raw)
To: Helge Deller
Cc: linux-kernel, Sergey Senozhatsky, Petr Mladek, Andrew Morton,
linux-xfs
On Wed, Sep 06, 2017 at 10:27:57PM +0200, Helge Deller wrote:
> Use the %pS instead of the %pF printk format specifier for printing symbols
> from direct addresses. This is needed for the ia64, ppc64 and parisc64
> architectures.
>
> Signed-off-by: Helge Deller <deller@gmx.de>
> Cc: "Darrick J. Wong" <darrick.wong@oracle.com>
> Cc: linux-xfs@vger.kernel.org
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> fs/xfs/xfs_error.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_error.c b/fs/xfs/xfs_error.c
> index 2f4feb9..028e50a 100644
> --- a/fs/xfs/xfs_error.c
> +++ b/fs/xfs/xfs_error.c
> @@ -344,7 +344,7 @@ xfs_verifier_error(
> {
> struct xfs_mount *mp = bp->b_target->bt_mount;
>
> - xfs_alert(mp, "Metadata %s detected at %pF, %s block 0x%llx",
> + xfs_alert(mp, "Metadata %s detected at %pS, %s block 0x%llx",
> bp->b_error == -EFSBADCRC ? "CRC error" : "corruption",
> __return_address, bp->b_ops->name, bp->b_bn);
>
> --
> 2.1.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-18 18:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1504729681-3504-1-git-send-email-deller@gmx.de>
2017-09-06 20:27 ` [PATCH 10/14] fs/xfs: Use %pS printk format for direct addresses Helge Deller
2017-09-08 7:38 ` Christoph Hellwig
2017-09-18 18:37 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).