From: Brian Foster <bfoster@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Eryu Guan <eguan@redhat.com>, Eric Sandeen <sandeen@redhat.com>,
fstests <fstests@vger.kernel.org>,
Zheng Liu <wenqing.lz@taobao.com>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH] test race when checking i_size on direct i/o read
Date: Tue, 19 Sep 2017 10:58:51 -0400 [thread overview]
Message-ID: <20170919145851.GD3487@bfoster.bfoster> (raw)
In-Reply-To: <20170919143406.GA7437@infradead.org>
On Tue, Sep 19, 2017 at 07:34:06AM -0700, Christoph Hellwig wrote:
> On Tue, Sep 19, 2017 at 10:13:52AM -0400, Brian Foster wrote:
> > Can we pass a boolean or flag to xfs_iomap_write_unwritten() to have it
> > update the incore i_size after unwritten extent conversion? Then move
> > (or remove) the associated update from xfs_dio_write_end_io().
>
> I don't think we even need a flag - all three callers of
> xfs_iomap_write_unwritten want to update the file size.
Sounds reasonable to me. I wasn't sure if there was anything special
about the pnfs case. isize should probably already be stable in the
writeback case, so perhaps this would be fine as long as we ensure the
in-core size only increases (as we currently do for di_size).
Brian
next prev parent reply other threads:[~2017-09-19 14:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <799f63d9-de03-eab3-1e6e-cd747aa04c36@redhat.com>
2017-09-19 7:36 ` [PATCH] test race when checking i_size on direct i/o read Eryu Guan
2017-09-19 14:13 ` Brian Foster
2017-09-19 14:34 ` Christoph Hellwig
2017-09-19 14:58 ` Brian Foster [this message]
2017-09-20 11:05 ` Eryu Guan
2017-09-20 12:55 ` Brian Foster
2017-09-21 10:09 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170919145851.GD3487@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).