From: Christoph Hellwig <hch@infradead.org>
To: Chandan Rajendra <chandan@linux.vnet.ibm.com>
Cc: linux-xfs@vger.kernel.org, hch@infradead.org, eguan@redhat.com,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] iomap_dio_rw: Allocate AIO completion queue before submitting dio
Date: Thu, 21 Sep 2017 05:52:53 -0700 [thread overview]
Message-ID: <20170921125253.GA10039@infradead.org> (raw)
In-Reply-To: <20170921095234.12401-1-chandan@linux.vnet.ibm.com>
> + if (iov_iter_rw(iter) == WRITE && !is_sync_kiocb(iocb) &&
> + !inode->i_sb->s_dio_done_wq) {
> + ret = sb_init_dio_done_wq(inode->i_sb);
Wrong indentation for the continuation of the if conditional.
Except for that the patch looks fine:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2017-09-21 12:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 9:52 [PATCH] iomap_dio_rw: Allocate AIO completion queue before submitting dio Chandan Rajendra
2017-09-21 12:52 ` Christoph Hellwig [this message]
2017-09-22 3:44 ` Eryu Guan
2017-09-22 6:33 ` [PATCH V2] " Chandan Rajendra
2017-09-22 7:07 ` Dave Chinner
2017-09-22 8:27 ` [PATCH V3] " Chandan Rajendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170921125253.GA10039@infradead.org \
--to=hch@infradead.org \
--cc=chandan@linux.vnet.ibm.com \
--cc=eguan@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox