From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: always swap the cow forks when swapping extents
Date: Tue, 26 Sep 2017 09:01:58 -0700 [thread overview]
Message-ID: <20170926160158.GG5020@magnolia> (raw)
In-Reply-To: <20170926144421.GB9530@infradead.org>
On Tue, Sep 26, 2017 at 07:44:21AM -0700, Christoph Hellwig wrote:
> On Sat, Sep 23, 2017 at 12:12:08AM -0700, Darrick J. Wong wrote:
> > Since the CoW fork exists as a secondary data structure to the data
> > fork, we must always swap cow forks during swapext. We also need to
> > swap the extent counts and reset the cowblocks tags.
>
> Do you have a test that triggers a problem without this? :)
Yes, but it doesn't trigger it reliably, so I've not yet sent it.
--D
>
> Looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-09-26 16:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-23 7:12 [PATCH] xfs: always swap the cow forks when swapping extents Darrick J. Wong
2017-09-25 11:33 ` Brian Foster
2017-09-26 14:44 ` Christoph Hellwig
2017-09-26 16:01 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170926160158.GG5020@magnolia \
--to=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox