public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] generic/447: not a quick test
@ 2017-09-28 16:40 Amir Goldstein
  2017-09-28 17:05 ` Darrick J. Wong
  2017-10-01  8:00 ` Christoph Hellwig
  0 siblings, 2 replies; 3+ messages in thread
From: Amir Goldstein @ 2017-09-28 16:40 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: Eryu Guan, Darrick J . Wong, fstests, linux-xfs

It hogged my cpu for a good 300s.
Test was inheritted from generic/176, which is not quick.

Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
 tests/generic/group | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/generic/group b/tests/generic/group
index f922b49..a9ad05d 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -449,7 +449,7 @@
 444 auto quick acl
 445 auto quick rw
 446 auto quick rw dangerous
-447 auto quick clone
+447 auto clone
 448 auto quick rw
 449 auto quick acl enospc
 450 auto quick rw
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] generic/447: not a quick test
  2017-09-28 16:40 [PATCH] generic/447: not a quick test Amir Goldstein
@ 2017-09-28 17:05 ` Darrick J. Wong
  2017-10-01  8:00 ` Christoph Hellwig
  1 sibling, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2017-09-28 17:05 UTC (permalink / raw)
  To: Amir Goldstein; +Cc: Christoph Hellwig, Eryu Guan, fstests, linux-xfs

On Thu, Sep 28, 2017 at 07:40:41PM +0300, Amir Goldstein wrote:
> It hogged my cpu for a good 300s.
> Test was inheritted from generic/176, which is not quick.

Hmm, takes 51s on some nice fast "pmem" here.  Not quick either. :(

Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> ---
>  tests/generic/group | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/generic/group b/tests/generic/group
> index f922b49..a9ad05d 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -449,7 +449,7 @@
>  444 auto quick acl
>  445 auto quick rw
>  446 auto quick rw dangerous
> -447 auto quick clone
> +447 auto clone
>  448 auto quick rw
>  449 auto quick acl enospc
>  450 auto quick rw
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] generic/447: not a quick test
  2017-09-28 16:40 [PATCH] generic/447: not a quick test Amir Goldstein
  2017-09-28 17:05 ` Darrick J. Wong
@ 2017-10-01  8:00 ` Christoph Hellwig
  1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2017-10-01  8:00 UTC (permalink / raw)
  To: Amir Goldstein
  Cc: Christoph Hellwig, Eryu Guan, Darrick J . Wong, fstests,
	linux-xfs

On Thu, Sep 28, 2017 at 07:40:41PM +0300, Amir Goldstein wrote:
> It hogged my cpu for a good 300s.
> Test was inheritted from generic/176, which is not quick.

True.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-10-01  8:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-28 16:40 [PATCH] generic/447: not a quick test Amir Goldstein
2017-09-28 17:05 ` Darrick J. Wong
2017-10-01  8:00 ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox