From: Dave Chinner <david@fromorbit.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org, Brian Foster <bfoster@redhat.com>,
Carlos Maiolino <cmaiolino@redhat.com>,
Dave Chinner <dchinner@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: move two more RT specific functions into CONFIG_XFS_RT
Date: Sat, 14 Oct 2017 09:08:25 +1100 [thread overview]
Message-ID: <20171013220825.GY15067@dastard> (raw)
In-Reply-To: <20171013120603.4135344-1-arnd@arndb.de>
On Fri, Oct 13, 2017 at 02:05:40PM +0200, Arnd Bergmann wrote:
> The last cleanup introduced two harmless warnings:
>
> fs/xfs/xfs_fsmap.c:480:1: warning: '__xfs_getfsmap_rtdev' defined but not used
> fs/xfs/xfs_fsmap.c:372:1: warning: 'xfs_getfsmap_rtdev_rtbitmap_helper' defined but not used
>
> This moves those two functions as well.
Curious. I didn't get those warnings on gcc 6.4 or 7.2 on x86-64.
Oh, CONFIG_XFS_DEBUG=y hides them, because it removes the "static"
declaration from them. Ok, that makes sense - I almost never build
a non-debug kernel. Have to make sure when I do config changes next
time to build without debug...
Thanks, Arnd!
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2017-10-13 22:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 12:05 [PATCH] xfs: move two more RT specific functions into CONFIG_XFS_RT Arnd Bergmann
2017-10-13 13:24 ` Brian Foster
2017-10-13 16:26 ` Darrick J. Wong
2017-10-13 22:08 ` Dave Chinner [this message]
2017-10-14 11:11 ` Brian Foster
2017-10-16 7:41 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171013220825.GY15067@dastard \
--to=david@fromorbit.com \
--cc=arnd@arndb.de \
--cc=bfoster@redhat.com \
--cc=cmaiolino@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=dchinner@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).