From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp1040.oracle.com ([141.146.126.69]:31414 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932337AbdJPTyk (ORCPT ); Mon, 16 Oct 2017 15:54:40 -0400 Date: Mon, 16 Oct 2017 12:54:36 -0700 From: "Darrick J. Wong" Subject: Re: [PATCH 08/30] xfs: probe the scrub ioctl Message-ID: <20171016195436.GI4703@magnolia> References: <150777244315.1724.6916081372861799350.stgit@magnolia> <150777249786.1724.13451740442676439052.stgit@magnolia> <20171016003912.GL3666@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171016003912.GL3666@dastard> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Dave Chinner Cc: linux-xfs@vger.kernel.org On Mon, Oct 16, 2017 at 11:39:12AM +1100, Dave Chinner wrote: > On Wed, Oct 11, 2017 at 06:41:37PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong > > > > Create a probe scrubber with id 0. This will be used by xfs_scrub to > > probe the kernel's abilities to scrub (and repair) the metadata. > > This no longer returns anything to userspace it indicate > capabilities. I can see that the previous patch checks for > valid/invalid input flags, so we have unknown feature > checking in place, just not obviously through the probe function > implementation. Can you expand this comment a little to explain > where the supported feature checks occur and so all that is required > here is a stub that does nothing? Ok. I propose: "Create a probe scrubber with id 0. This will be used by xfs_scrub to probe the kernel's abilities to scrub (and repair) the metadata. We do this by validating the ioctl inputs from userspace, preparing the filesystem for a scrub (or a repair) operation, and immediately returning to userspace. Userspace can use the returned errno and structure state to decide (in broad terms) if scrub/repair are supported by the running kernel." --D > > Otherwise, consider it: > > Reviewed-by: Dave Chinner > > -- > Dave Chinner > david@fromorbit.com > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html